Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: content/child/web_process_memory_dump_impl.h

Issue 1308523004: Implement GetSkiaTraceMemoryDump and AddSuballocation on chrome blink platform impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web_cache_move
Patch Set: $Rebase. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/web_process_memory_dump_impl.h
diff --git a/content/child/web_process_memory_dump_impl.h b/content/child/web_process_memory_dump_impl.h
index 221db61f1f6dee494656ab52d00eca007308b724..7ae8aabf64bdd51b0c5aec1a014ebdc2835b2a5b 100644
--- a/content/child/web_process_memory_dump_impl.h
+++ b/content/child/web_process_memory_dump_impl.h
@@ -7,7 +7,7 @@
#include "base/containers/scoped_ptr_hash_map.h"
#include "base/gtest_prod_util.h"
-#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
#include "content/common/content_export.h"
#include "third_party/WebKit/public/platform/WebProcessMemoryDump.h"
@@ -18,6 +18,10 @@ class ProcessMemoryDump;
} // namespace base
} // namespace trace_event
+namespace skia {
+class SkTraceMemoryDump_Chrome;
+} // namespace skia
+
namespace content {
class WebMemoryAllocatorDumpImpl;
@@ -53,6 +57,11 @@ class CONTENT_EXPORT WebProcessMemoryDumpImpl final
int importance);
virtual void AddOwnershipEdge(blink::WebMemoryAllocatorDumpGuid source,
blink::WebMemoryAllocatorDumpGuid target);
+ virtual void AddSuballocation(blink::WebMemoryAllocatorDumpGuid source,
+ const blink::WebString& targetNodeName);
+ virtual SkTraceMemoryDump* CreateDumpAdapterForSkia(
+ blink::WebMemoryDumpLevelOfDetail levelOfDetail,
+ const blink::WebString& dumpNamePrefix);
const base::trace_event::ProcessMemoryDump* process_memory_dump() const {
return process_memory_dump_;
@@ -80,6 +89,9 @@ class CONTENT_EXPORT WebProcessMemoryDumpImpl final
scoped_ptr<WebMemoryAllocatorDumpImpl>>
memory_allocator_dumps_;
+ // Stores SkTraceMemoryDump for the current ProcessMemoryDump.
Primiano Tucci (use gerrit) 2015/09/09 16:16:42 Please say: this class handles the memory ownershi
ssid 2015/09/10 11:08:26 Done.
+ ScopedVector<skia::SkTraceMemoryDump_Chrome> sk_trace_dump_list_;
+
DISALLOW_COPY_AND_ASSIGN(WebProcessMemoryDumpImpl);
};
« no previous file with comments | « no previous file | content/child/web_process_memory_dump_impl.cc » ('j') | content/child/web_process_memory_dump_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698