Implement GetSkiaTraceMemoryDump and AddSuballocation on chrome blink platform impl

content/child/web_process_memory_dump_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_CHILD_WEB_PROCESS_MEMORY_DUMP_IMPL_H_
 #define CONTENT_CHILD_WEB_PROCESS_MEMORY_DUMP_IMPL_H_
 
 #include "base/containers/scoped_ptr_hash_map.h"
 #include "base/gtest_prod_util.h"
-#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
 #include "content/common/content_export.h"
 #include "third_party/WebKit/public/platform/WebProcessMemoryDump.h"
 
 namespace base {
 namespace trace_event {
 class MemoryAllocatorDump;
 class ProcessMemoryDump;
 }  // namespace base
 }  // namespace trace_event
 
+namespace skia {
+class SkTraceMemoryDump_Chrome;
+}  // namespace skia
+
 namespace content {
 
 class WebMemoryAllocatorDumpImpl;
 
 // Implements the blink::WebProcessMemoryDump interface by means of proxying the
 // calls to createMemoryAllocatorDump() to the underlying
 // base::trace_event::ProcessMemoryDump instance.
 class CONTENT_EXPORT WebProcessMemoryDumpImpl final
     : public NON_EXPORTED_BASE(blink::WebProcessMemoryDump) {
  public:
@@ skipping 15 matching lines @@
       blink::WebMemoryAllocatorDumpGuid guid);
   virtual blink::WebMemoryAllocatorDump* getMemoryAllocatorDump(
       const blink::WebString& absolute_name) const;
   virtual void clear();
   virtual void takeAllDumpsFrom(blink::WebProcessMemoryDump* other);
   virtual void AddOwnershipEdge(blink::WebMemoryAllocatorDumpGuid source,
                                 blink::WebMemoryAllocatorDumpGuid target,
                                 int importance);
   virtual void AddOwnershipEdge(blink::WebMemoryAllocatorDumpGuid source,
                                 blink::WebMemoryAllocatorDumpGuid target);
+  virtual void AddSuballocation(blink::WebMemoryAllocatorDumpGuid source,
+                                const blink::WebString& targetNodeName);
+  virtual SkTraceMemoryDump* CreateDumpAdapterForSkia(
+      blink::WebMemoryDumpLevelOfDetail levelOfDetail,
+      const blink::WebString& dumpNamePrefix);
 
   const base::trace_event::ProcessMemoryDump* process_memory_dump() const {
     return process_memory_dump_;
   }
 
  private:
   FRIEND_TEST_ALL_PREFIXES(WebProcessMemoryDumpImplTest, IntegrationTest);
 
   blink::WebMemoryAllocatorDump* createWebMemoryAllocatorDump(
       base::trace_event::MemoryAllocatorDump* memory_allocator_dump);
 
   // Only for the case of ProcessMemoryDump being owned (i.e. the default ctor).
   scoped_ptr<base::trace_event::ProcessMemoryDump> owned_process_memory_dump_;
 
   // The underlying ProcessMemoryDump instance to which the
   // createMemoryAllocatorDump() calls will be proxied to.
   base::trace_event::ProcessMemoryDump* process_memory_dump_;  // Not owned.
 
   // Reverse index of MemoryAllocatorDump -> WebMemoryAllocatorDumpImpl wrapper.
   // By design WebMemoryDumpProvider(s) are not supposed to hold the pointer
   // to the WebProcessMemoryDump passed as argument of the onMemoryDump() call.
   // Those pointers are valid only within the scope of the call and can be
   // safely torn down once the WebProcessMemoryDumpImpl itself is destroyed.
   base::ScopedPtrHashMap<base::trace_event::MemoryAllocatorDump*,
                          scoped_ptr<WebMemoryAllocatorDumpImpl>>
       memory_allocator_dumps_;
 
+  // Stores SkTraceMemoryDump for the current ProcessMemoryDump.

[Primiano Tucci (use gerrit), 2015/09/09 16:16:42]

Please say: this class handles the memory ownership of the SkTraceMemoryDump
instace returned. It is guaranteed to be valid through all the lifetime of
WebProcessMemoryDumpImpl.

[ssid, 2015/09/10 11:08:26]

Done.

+  ScopedVector<skia::SkTraceMemoryDump_Chrome> sk_trace_dump_list_;
+
   DISALLOW_COPY_AND_ASSIGN(WebProcessMemoryDumpImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_CHILD_WEB_PROCESS_MEMORY_DUMP_IMPL_H_