Create separate entry points for the various flavors of drawRect

Create separate entry points for the various flavors of drawRect

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/b6b513b805c37dc80999261c5d03e7af1976542e

[joshualitt, 2015-08-20 20:27:42]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, robertphillips@google.com

[joshualitt, 2015-08-20 20:27:42]

A mindless CL to break out some of the overloading of drawRect

[bsalomon, 2015-08-21 15:51:44]

https://codereview.chromium.org/1308503002/diff/1/src/gpu/GrDrawContext.cpp
File src/gpu/GrDrawContext.cpp (right):

https://codereview.chromium.org/1308503002/diff/1/src/gpu/GrDrawContext.cpp#n...
src/gpu/GrDrawContext.cpp:307: fDrawTarget->drawBWRect(pipelineBuilder, color,
viewMatrix, rect);
Not crazy about "BW", very unclear. We already use NonAA below which is more
accurate.

https://codereview.chromium.org/1308503002/diff/1/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/1308503002/diff/1/src/gpu/GrDrawTarget.h#newc...
src/gpu/GrDrawTarget.h:123: void drawBWRect(const GrPipelineBuilder&
pipelineBuilder,
eek... didn't know we had this too. Don't like the inconsistency and think BW is
the less informative of our two ways of naming things.

[joshualitt, 2015-08-21 15:56:29]

On 2015/08/21 15:51:44, bsalomon wrote:
> https://codereview.chromium.org/1308503002/diff/1/src/gpu/GrDrawContext.cpp
> File src/gpu/GrDrawContext.cpp (right):
> 
>
https://codereview.chromium.org/1308503002/diff/1/src/gpu/GrDrawContext.cpp#n...
> src/gpu/GrDrawContext.cpp:307: fDrawTarget->drawBWRect(pipelineBuilder, color,
> viewMatrix, rect);
> Not crazy about "BW", very unclear. We already use NonAA below which is more
> accurate.
> 
> https://codereview.chromium.org/1308503002/diff/1/src/gpu/GrDrawTarget.h
> File src/gpu/GrDrawTarget.h (right):
> 
>
https://codereview.chromium.org/1308503002/diff/1/src/gpu/GrDrawTarget.h#newc...
> src/gpu/GrDrawTarget.h:123: void drawBWRect(const GrPipelineBuilder&
> pipelineBuilder,
> eek... didn't know we had this too. Don't like the inconsistency and think BW
is
> the less informative of our two ways of naming things.

do you mind if I just globally rename all of the places we use BW to NonAA in a
follow on patch?

[bsalomon, 2015-08-21 16:00:12]

On 2015/08/21 15:56:29, joshualitt wrote:
> On 2015/08/21 15:51:44, bsalomon wrote:
> > https://codereview.chromium.org/1308503002/diff/1/src/gpu/GrDrawContext.cpp
> > File src/gpu/GrDrawContext.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1308503002/diff/1/src/gpu/GrDrawContext.cpp#n...
> > src/gpu/GrDrawContext.cpp:307: fDrawTarget->drawBWRect(pipelineBuilder,
color,
> > viewMatrix, rect);
> > Not crazy about "BW", very unclear. We already use NonAA below which is more
> > accurate.
> > 
> > https://codereview.chromium.org/1308503002/diff/1/src/gpu/GrDrawTarget.h
> > File src/gpu/GrDrawTarget.h (right):
> > 
> >
>
https://codereview.chromium.org/1308503002/diff/1/src/gpu/GrDrawTarget.h#newc...
> > src/gpu/GrDrawTarget.h:123: void drawBWRect(const GrPipelineBuilder&
> > pipelineBuilder,
> > eek... didn't know we had this too. Don't like the inconsistency and think
BW
> is
> > the less informative of our two ways of naming things.
> 
> do you mind if I just globally rename all of the places we use BW to NonAA in
a
> follow on patch?

sgtm, lgtm

[joshualitt, 2015-08-21 17:18:53]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-08-21 17:18:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1308503002/#ps20001
(title: "rebase onto master")

[commit-bot: I haz the power, 2015-08-21 17:19:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308503002/20001

[commit-bot: I haz the power, 2015-08-21 17:25:22]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b6b513b805c37dc80999261c5d03e7af1976542e