Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: tests/compiler/dart2js/mock_compiler.dart

Issue 13084013: Handle assignability for Send and SendSet (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Debug code removed. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/mock_compiler.dart
diff --git a/tests/compiler/dart2js/mock_compiler.dart b/tests/compiler/dart2js/mock_compiler.dart
index 07350f9e6aecbc827d441198bd4b0cd6761d1fb2..31c70d2054660bc8ad91f17bd4efb786186aa225 100644
--- a/tests/compiler/dart2js/mock_compiler.dart
+++ b/tests/compiler/dart2js/mock_compiler.dart
@@ -172,6 +172,7 @@ const String DEFAULT_ISOLATE_HELPERLIB = r'''
class _WorkerBase {}''';
class MockCompiler extends Compiler {
+ api.DiagnosticHandler diagnosticHandler;
List<WarningMessage> warnings;
List<WarningMessage> errors;
final Map<String, SourceFile> sourceFiles;
@@ -255,6 +256,8 @@ class MockCompiler extends Compiler {
void reportWarning(Node node, var message) {
if (message is! Message) message = message.message;
warnings.add(new WarningMessage(node, message));
+ reportDiagnostic(spanFromNode(node),
+ 'Warning: $message', api.Diagnostic.WARNING);
}
void reportError(Node node, var message) {
@@ -264,6 +267,8 @@ class MockCompiler extends Compiler {
}
if (message is! Message) message = message.message;
errors.add(new WarningMessage(node, message));
+ reportDiagnostic(spanFromNode(node),
+ 'Error: $message', api.Diagnostic.ERROR);
}
void reportMessage(SourceSpan span, var message, api.Diagnostic kind) {
@@ -273,10 +278,17 @@ class MockCompiler extends Compiler {
} else {
warnings.add(diagnostic);
}
+ reportDiagnostic(span, "$message", kind);
}
- void reportDiagnostic(SourceSpan span, String message, var kind) {
- print(message);
+ void reportDiagnostic(SourceSpan span, String message, api.Diagnostic kind) {
+ if (diagnosticHandler != null) {
+ if (span != null) {
+ diagnosticHandler(span.uri, span.begin, span.end, message, kind);
+ } else {
+ diagnosticHandler(null, null, null, message, kind);
+ }
+ }
}
bool get compilationFailed => !errors.isEmpty;
@@ -318,7 +330,7 @@ class MockCompiler extends Compiler {
parseScript(String text, [LibraryElement library]) {
if (library == null) library = mainApp;
- parseUnit(text, this, library);
+ parseUnit(text, this, library, registerSource);
}
void scanBuiltinLibraries() {

Powered by Google App Engine
This is Rietveld 408576698