Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2212)

Unified Diff: tests/compiler/dart2js/analyze_api_test.dart

Issue 13084013: Handle assignability for Send and SendSet (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Debug code removed. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/analyze_api_test.dart
diff --git a/tests/compiler/dart2js/analyze_api_test.dart b/tests/compiler/dart2js/analyze_api_test.dart
index 93ae53ce7e1f3797d9ce099bce7b1a611f2bed43..6e1f9479832a359feec01e1327f3381185371d78 100644
--- a/tests/compiler/dart2js/analyze_api_test.dart
+++ b/tests/compiler/dart2js/analyze_api_test.dart
@@ -27,8 +27,15 @@ import '../../../sdk/lib/_internal/libraries.dart';
// TODO(johnniwinther): Support canonical URIs as keys and message kinds as
// values.
const Map<String,List<String>> WHITE_LIST = const {
- 'html_dart2js.dart': const ['Warning: Using "new Symbol"', // Issue 10565.
- 'Warning: unreachable code'], // Issue 10617.
+ 'html_dart2js.dart':
+ const ['Warning: Using "new Symbol"', // Issue 10565.
+ 'Warning: unreachable code', // Issue 10617.
+ // Issue 10688:
+ 'Warning: no property named',
+ 'Warning: WindowBase is not assignable to EventTarget',
+ "Warning: 'UnsupportedError' is not callable",
+ "Warning: no method named getBoundingClientRect",
+ "Warning: no operator [] in class Iterable"],
};
class CollectingDiagnosticHandler extends FormattingDiagnosticHandler {
@@ -79,7 +86,7 @@ class CollectingDiagnosticHandler extends FormattingDiagnosticHandler {
for (String file in whiteListMap.keys) {
if (path.endsWith(file)) {
for (String messagePart in whiteListMap[file].keys) {
- if (message.contains(messagePart)) {
+ if (message != null && message.contains(messagePart)) {
karlklose 2013/05/17 09:36:53 Where are empty messages coming from? Is this nece
Johnni Winther 2013/05/17 11:46:33 Not anymore. Removed.
whiteListMap[file][messagePart]++;
return true;
}

Powered by Google App Engine
This is Rietveld 408576698