Handle assignability for Send and SendSet

tests/compiler/dart2js/analyze_api_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyze_api;
 
 import "package:expect/expect.dart";
 import 'dart:uri';
 import 'dart:io';
 import '../../../sdk/lib/_internal/compiler/compiler.dart' as api;
 import '../../../sdk/lib/_internal/compiler/implementation/apiimpl.dart';
 import '../../../sdk/lib/_internal/compiler/implementation/dart2jslib.dart'
     hide Compiler;
 import '../../../sdk/lib/_internal/compiler/implementation/filenames.dart';
 import '../../../sdk/lib/_internal/compiler/implementation/source_file_provider.dart';
 import '../../../sdk/lib/_internal/libraries.dart';
 
 /**
  * Map of white-listed warnings and errors.
  *
  * Only add a white-listing together with a bug report to dartbug.com and add
  * the bug issue number as a comment on the white-listing.
  *
  * Use an identifiable suffix of the file uri as key. Use a fixed substring of
  * the error/warning message in the list of white-listings for each file.
  */
 // TODO(johnniwinther): Support canonical URIs as keys and message kinds as
 // values.
 const Map<String,List<String>> WHITE_LIST = const {
-  'html_dart2js.dart': const ['Warning: Using "new Symbol"', // Issue 10565.
-                              'Warning: unreachable code'], // Issue 10617.
+  'html_dart2js.dart':
+      const ['Warning: Using "new Symbol"', // Issue 10565.
+             'Warning: unreachable code', // Issue 10617.
+             // Issue 10688:
+             'Warning: no property named',
+             'Warning: WindowBase is not assignable to EventTarget',
+             "Warning: 'UnsupportedError' is not callable",
+             "Warning: no method named getBoundingClientRect",
+             "Warning: no operator [] in class Iterable"],
 };
 
 class CollectingDiagnosticHandler extends FormattingDiagnosticHandler {
   bool hasWarnings = false;
   bool hasErrors = false;
 
   Map<String,Map<String,int>> whiteListMap = new Map<String,Map<String,int>>();
 
   CollectingDiagnosticHandler(SourceFileProvider provider) : super(provider) {
     WHITE_LIST.forEach((String file, List<String> messageParts) {
@@ skipping 30 matching lines @@
   }
 
   bool checkWhiteList(Uri uri, String message) {
     if (uri == null) {
       return false;
     }
     String path = uri.path;
     for (String file in whiteListMap.keys) {
       if (path.endsWith(file)) {
         for (String messagePart in whiteListMap[file].keys) {
-          if (message.contains(messagePart)) {
+          if (message != null && message.contains(messagePart)) {

[karlklose, 2013/05/17 09:36:53]

Where are empty messages coming from? Is this necessary?

[Johnni Winther, 2013/05/17 11:46:33]

Not anymore. Removed.

             whiteListMap[file][messagePart]++;
             return true;
           }
         }
       }
     }
     return false;
   }
 
   void diagnosticHandler(Uri uri, int begin, int end, String message,
@@ skipping 33 matching lines @@
       libraryRoot, libraryRoot,
       <String>['--analyze-only', '--analyze-all',
                '--categories=Client,Server']);
   compiler.librariesToAnalyzeWhenRun = uriList;
   compiler.run(null);
   Expect.isFalse(handler.hasWarnings);
   Expect.isFalse(handler.hasErrors);
   Expect.isTrue(handler.checkWhiteListUse());
   handler.reportWhiteListUse();
 }