Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1308273007: Make classes and structures in core/inspector fast-allocated. (Closed)

Created:
5 years, 3 months ago by tasak
Modified:
5 years, 3 months ago
Reviewers:
haraken, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make classes and structures in core/inspector fast-allocated. Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201632

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -3 lines) Patch
M Source/core/inspector/AsyncCallTracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/IdentifiersFactory.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InjectedScript.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InjectedScriptHostClient.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorBaseAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorState.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorTaskRunner.h View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.h View 6 chunks +39 lines, -0 lines 0 comments Download
M Source/core/inspector/InstanceCounters.h View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/inspector/LayoutEditor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/MainThreadDebugger.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/PromiseTracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/RemoteObjectId.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/ScriptCallFrame.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/V8AsyncCallTracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/v8/ScriptBreakpoint.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/v8/V8Debugger.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/v8/V8DebuggerClient.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/v8/V8DebuggerListener.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/inspector/v8/V8JavaScriptCallFrame.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tasak
Would you review this CL?
5 years, 3 months ago (2015-09-01 04:01:44 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-01 04:45:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308273007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308273007/20001
5 years, 3 months ago (2015-09-02 08:24:45 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 09:30:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201632

Powered by Google App Engine
This is Rietveld 408576698