Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1308223003: Remove applyStatefulResource interface from SVGClipPainter (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove applyStatefulResource interface from SVGClipPainter applyClippingToContext is equally "stateful", so the two entrypoints does not seem warranted. Fold applyClippingToContext into applyStatefulResource and then rename it to prepareEffect (to match mask and filter). Similarly rename postApplyStatefulResource to finishEffect. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -25 lines) Patch
M Source/core/paint/DeprecatedPaintLayerPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/SVGClipPainter.h View 2 chunks +2 lines, -8 lines 0 comments Download
M Source/core/paint/SVGClipPainter.cpp View 5 chunks +9 lines, -13 lines 0 comments Download
M Source/core/paint/SVGPaintContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
Trybot unhappiness unrelated, but hopefully the minor behavior change in here won't cause to much ...
5 years, 3 months ago (2015-08-26 18:24:35 UTC) #2
f(malita)
LGTM!
5 years, 3 months ago (2015-08-26 18:48:03 UTC) #3
pdr.
LGTM
5 years, 3 months ago (2015-08-26 20:41:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308223003/1
5 years, 3 months ago (2015-08-26 20:41:31 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 23:53:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201262

Powered by Google App Engine
This is Rietveld 408576698