Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: Source/core/paint/SVGClipPainter.h

Issue 1308223003: Remove applyStatefulResource interface from SVGClipPainter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayerPainter.cpp ('k') | Source/core/paint/SVGClipPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/SVGClipPainter.h
diff --git a/Source/core/paint/SVGClipPainter.h b/Source/core/paint/SVGClipPainter.h
index ec98b74c00a5afbe96652786d97e93df3fed14ea..5543bf7e546af96c373f75a1d563def7f54660df 100644
--- a/Source/core/paint/SVGClipPainter.h
+++ b/Source/core/paint/SVGClipPainter.h
@@ -10,7 +10,6 @@
namespace blink {
-class AffineTransform;
class GraphicsContext;
class LayoutObject;
class LayoutSVGResourceClipper;
@@ -28,13 +27,8 @@ public:
// FIXME: Filters are also stateful resources that could benefit from having their state managed
// on the caller stack instead of the current hashmap. We should look at refactoring these
// into a general interface that can be shared.
- bool applyStatefulResource(const LayoutObject&, GraphicsContext*, ClipperState&);
- void postApplyStatefulResource(const LayoutObject&, GraphicsContext*, ClipperState&);
-
- // clipPath can be clipped too, but don't have a boundingBox or paintInvalidationRect. So we can't call
- // applyResource directly and use the rects from the object, since they are empty for LayoutSVGResources
- // FIXME: We made applyClippingToContext public because we cannot call applyResource on HTML elements (it asserts on LayoutObject::objectBoundingBox)
- bool applyClippingToContext(const LayoutObject&, const FloatRect&, const FloatRect&, GraphicsContext*, ClipperState&);
+ bool prepareEffect(const LayoutObject&, const FloatRect&, const FloatRect&, GraphicsContext*, ClipperState&);
+ void finishEffect(const LayoutObject&, GraphicsContext*, ClipperState&);
private:
void drawClipMaskContent(GraphicsContext*, const LayoutObject&, const FloatRect& targetBoundingBox, const FloatRect& targetPaintInvalidationRect);
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayerPainter.cpp ('k') | Source/core/paint/SVGClipPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698