Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 1308113007: fix gen-postmortem-metadata.py for kInObjectPropertiesOffset (Closed)

Created:
5 years, 3 months ago by ofrobots
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

fix gen-postmortem-metadata.py for kInObjectPropertiesOffset This is causing build breaks for Node.js w/ V8 4.6. Map::kInObjectPropertiesOffset was been replaced by kInObjectPropertiesOrConstructorFunctionIndexOffset in https://codereview.chromium.org/1276533003. This is causing the post-mortem debug information generation to fail. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/5434d052f138adc0933c20ad24cc3d84555be53d Cr-Commit-Position: refs/heads/master@{#30536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gen-postmortem-metadata.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ofrobots
5 years, 3 months ago (2015-09-02 00:08:46 UTC) #1
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-02 06:42:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308113007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308113007/1
5 years, 3 months ago (2015-09-02 07:21:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 07:45:32 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 07:45:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5434d052f138adc0933c20ad24cc3d84555be53d
Cr-Commit-Position: refs/heads/master@{#30536}

Powered by Google App Engine
This is Rietveld 408576698