Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1276533003: [runtime] Store constructor function index on primitive maps. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Store constructor function index on primitive maps. This way we can greatly simplify the different variants of ToObject in our codebase and make them more uniform and robust. Adding a new primitive doesn't require finding and changing all those places again, but it is sufficient to setup the constructor function index when allocating the map. We use the inobject properties field of Map, which is invalid primitive maps anyway. R=jkummerow@chromium.org Committed: https://crrev.com/6c743b2b39ae4333e9451f99f3edb3e17e7ad2a5 Cr-Commit-Position: refs/heads/master@{#30119}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix arm failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -277 lines) Patch
M src/arm/builtins-arm.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/field-index-inl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +25 lines, -8 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 6 chunks +31 lines, -82 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ic/handler-compiler.cc View 2 chunks +6 lines, -22 lines 0 comments Download
M src/ic/ic-inl.h View 1 chunk +7 lines, -18 lines 0 comments Download
M src/layout-descriptor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/layout-descriptor-inl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/objects.h View 6 chunks +31 lines, -11 lines 0 comments Download
M src/objects.cc View 13 chunks +35 lines, -77 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 7 chunks +43 lines, -15 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/runtime/runtime-collections.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Hey Jakob, Yang, This is the CL we talked about offline earlier. Please take a ...
5 years, 4 months ago (2015-08-11 13:55:15 UTC) #2
Jakob Kummerow
LGTM with comments that you have addressed already :-) https://codereview.chromium.org/1276533003/diff/1/src/arm/builtins-arm.cc File src/arm/builtins-arm.cc (right): https://codereview.chromium.org/1276533003/diff/1/src/arm/builtins-arm.cc#newcode446 src/arm/builtins-arm.cc:446: ...
5 years, 4 months ago (2015-08-11 16:01:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276533003/20001
5 years, 4 months ago (2015-08-11 19:34:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-11 19:36:12 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 19:36:23 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c743b2b39ae4333e9451f99f3edb3e17e7ad2a5
Cr-Commit-Position: refs/heads/master@{#30119}

Powered by Google App Engine
This is Rietveld 408576698