Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1308063002: Add four more tests to CFI buildbot. (Closed)

Created:
5 years, 4 months ago by krasin
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke, pcc1
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add four more tests to CFI buildbot. BUG=chromium:457523 Committed: https://crrev.com/43d9175c4c2cac6295c7a804a438e948821eec9e Cr-Commit-Position: refs/heads/master@{#352954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 4 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
krasin
Note: this didn't go through the CFI trybot due to https://crbug.com/521143
5 years, 4 months ago (2015-08-21 18:42:40 UTC) #2
krasin
Peter, can you please approve this CL? CFI trybot is (finally!) green.
5 years, 2 months ago (2015-10-06 20:48:42 UTC) #4
pcc1
LGTM but I'm not an OWNER.
5 years, 2 months ago (2015-10-07 11:27:59 UTC) #7
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-07 18:09:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308063002/1
5 years, 2 months ago (2015-10-07 19:04:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 21:56:58 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 21:57:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43d9175c4c2cac6295c7a804a438e948821eec9e
Cr-Commit-Position: refs/heads/master@{#352954}

Powered by Google App Engine
This is Rietveld 408576698