Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: extensions/utility/unpacker.h

Issue 1308013005: Add scoped_ptr-safe base::Value to Dictionary/List conversion functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made conversions static members. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/utility/unpacker.h
diff --git a/extensions/utility/unpacker.h b/extensions/utility/unpacker.h
index 7e5a7e47c75347b94e3aeac8e482c7c5f98a4040..eaffc7b4c6217bfa666094d68d9bfa2b26625bb9 100644
--- a/extensions/utility/unpacker.h
+++ b/extensions/utility/unpacker.h
@@ -55,8 +55,7 @@ class Unpacker {
bool DumpMessageCatalogsToFile();
// Parse the manifest.json file inside the extension (not in the header).
- // Caller takes ownership of return value.
- base::DictionaryValue* ReadManifest();
+ scoped_ptr<base::DictionaryValue> ReadManifest();
// Parse all _locales/*/messages.json files inside the extension.
bool ReadAllMessageCatalogs(const std::string& default_locale);
« no previous file with comments | « extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc ('k') | extensions/utility/unpacker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698