Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: extensions/utility/unpacker.h

Issue 1308013005: Add scoped_ptr-safe base::Value to Dictionary/List conversion functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made conversions static members. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_UTILITY_UNPACKER_H_ 5 #ifndef EXTENSIONS_UTILITY_UNPACKER_H_
6 #define EXTENSIONS_UTILITY_UNPACKER_H_ 6 #define EXTENSIONS_UTILITY_UNPACKER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 // of sending them over IPC, since they are so large. Returns true on 48 // of sending them over IPC, since they are so large. Returns true on
49 // success. 49 // success.
50 bool DumpImagesToFile(); 50 bool DumpImagesToFile();
51 51
52 // Write the decoded messages to kDecodedMessageCatalogsFilename. We do this 52 // Write the decoded messages to kDecodedMessageCatalogsFilename. We do this
53 // instead of sending them over IPC, since they are so large. Returns true on 53 // instead of sending them over IPC, since they are so large. Returns true on
54 // success. 54 // success.
55 bool DumpMessageCatalogsToFile(); 55 bool DumpMessageCatalogsToFile();
56 56
57 // Parse the manifest.json file inside the extension (not in the header). 57 // Parse the manifest.json file inside the extension (not in the header).
58 // Caller takes ownership of return value. 58 scoped_ptr<base::DictionaryValue> ReadManifest();
59 base::DictionaryValue* ReadManifest();
60 59
61 // Parse all _locales/*/messages.json files inside the extension. 60 // Parse all _locales/*/messages.json files inside the extension.
62 bool ReadAllMessageCatalogs(const std::string& default_locale); 61 bool ReadAllMessageCatalogs(const std::string& default_locale);
63 62
64 // Decodes the image at the given path and puts it in our list of decoded 63 // Decodes the image at the given path and puts it in our list of decoded
65 // images. 64 // images.
66 bool AddDecodedImage(const base::FilePath& path); 65 bool AddDecodedImage(const base::FilePath& path);
67 66
68 // Parses the catalog at the given path and puts it in our list of parsed 67 // Parses the catalog at the given path and puts it in our list of parsed
69 // catalogs. 68 // catalogs.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 101
103 // The last error message that was set. Empty if there were no errors. 102 // The last error message that was set. Empty if there were no errors.
104 base::string16 error_message_; 103 base::string16 error_message_;
105 104
106 DISALLOW_COPY_AND_ASSIGN(Unpacker); 105 DISALLOW_COPY_AND_ASSIGN(Unpacker);
107 }; 106 };
108 107
109 } // namespace extensions 108 } // namespace extensions
110 109
111 #endif // EXTENSIONS_UTILITY_UNPACKER_H_ 110 #endif // EXTENSIONS_UTILITY_UNPACKER_H_
OLDNEW
« no previous file with comments | « extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc ('k') | extensions/utility/unpacker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698