Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1307943011: Simple variable renaming: remove transport (Closed)

Created:
5 years, 3 months ago by guoweis_left_chromium
Modified:
5 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simple variable renaming: remove transport. Based on feedback from https://codereview.chromium.org/1315223002, removing all "transport" from variable names. BUG=webrtc:4784 Committed: https://crrev.com/5b380551e511287fabf9f89b45db3f371542219d Cr-Commit-Position: refs/heads/master@{#346855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M chrome/browser/extensions/api/preference/preference_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_preferences_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_ui_prefs.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/renderer_preferences.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/renderer_preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/port_allocator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/port_allocator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307943011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307943011/1
5 years, 3 months ago (2015-09-01 23:49:06 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-01 23:49:08 UTC) #4
guoweis_left_chromium
On 2015/09/01 23:49:08, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 3 months ago (2015-09-01 23:50:15 UTC) #6
not at google - send to devlin
extensions lgtm
5 years, 3 months ago (2015-09-01 23:50:59 UTC) #8
guoweis_left_chromium
PTAL for this simple renaming CL.
5 years, 3 months ago (2015-09-01 23:51:09 UTC) #10
Nico
lgtm
5 years, 3 months ago (2015-09-01 23:54:00 UTC) #11
Sergey Ulanov
lgtm
5 years, 3 months ago (2015-09-02 00:05:30 UTC) #12
Will Harris
rs lgtm for content/common/view_messages.h
5 years, 3 months ago (2015-09-02 00:33:05 UTC) #13
pthatcher2
lgtm
5 years, 3 months ago (2015-09-02 04:53:33 UTC) #14
kinuko
lgtm
5 years, 3 months ago (2015-09-02 05:23:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307943011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307943011/1
5 years, 3 months ago (2015-09-02 05:49:05 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 06:53:53 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 06:54:46 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b380551e511287fabf9f89b45db3f371542219d
Cr-Commit-Position: refs/heads/master@{#346855}

Powered by Google App Engine
This is Rietveld 408576698