Add `privacy.network.webRTCNonProxiedUdpTransportEnabled` to extensions API

Add `privacy.network.webRTCNonProxiedUdpTransportEnabled` to extensions API

Expose the preference to extensions' privacy API. Disabling this preference prevents non-proxied UDP to be used as it leads to IP leak when using WebRTC. Currently, this is effectively disabling all UDP traffic until UDP supporting proxy is available in chrome.

This is based on an ongoing CL https://codereview.chromium.org/1309543004

BUG=webrtc:4784
Committed: https://crrev.com/be2e0415f2fe42c419ce1660c9acd331f3a174ba
Cr-Commit-Position: refs/heads/master@{#346786}

[guoweis_left_chromium, 2015-08-28 16:29:24]

guoweis@chromium.org changed reviewers:
+ juberti@chromium.org, msramek@chromium.org, pthatcher@chromium.org

[guoweis_left_chromium, 2015-08-28 16:29:56]

guoweis@chromium.org changed reviewers:
+ brettw@chromium.org

[guoweis_left_chromium, 2015-08-28 16:29:56]

PTAL

[juberti, 2015-08-28 17:27:18]

juberti@google.com changed reviewers:
+ juberti@google.com

[juberti, 2015-08-28 17:27:19]

https://codereview.chromium.org/1315223002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/privacy.json (right):

https://codereview.chromium.org/1315223002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/privacy.json:28: "description": "If enabled, Chrome
will use non-proxied UDP transport to connect to peers or TURN servers when
using WebRTC. Since most proxy servers don't handle UDP, using UDP possibly
exposes user's IP address. Turning this off force WebRTC to only use TCP. This
preference's value is a boolean, defaulting to <code>true</code>."
Should mention that this will hurt performance and increase load on the proxy.

[guoweis_left_chromium, 2015-08-28 17:32:26]

PTAL.

https://codereview.chromium.org/1315223002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/privacy.json (right):

https://codereview.chromium.org/1315223002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/privacy.json:28: "description": "If enabled, Chrome
will use non-proxied UDP transport to connect to peers or TURN servers when
using WebRTC. Since most proxy servers don't handle UDP, using UDP possibly
exposes user's IP address. Turning this off force WebRTC to only use TCP. This
preference's value is a boolean, defaulting to <code>true</code>."
On 2015/08/28 17:27:19, juberti wrote:
> Should mention that this will hurt performance and increase load on the proxy.

Done.

[juberti, 2015-08-28 17:46:55]

lgtm with minor text change

https://codereview.chromium.org/1315223002/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/privacy.json (right):

https://codereview.chromium.org/1315223002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/privacy.json:28: "description": "If enabled, Chrome
is allowed to use non-proxied UDP transport to connect to peers or TURN servers
when using WebRTC. Since most proxy servers don't handle UDP, using UDP possibly
exposes user's IP address. Turning this off effectively forces WebRTC to only
use TCP for now, until UDP proxy support is availabe in Chrome. It also might
hurt media performance and increase the load for proxy servers. This
preference's value is a boolean, defaulting to <code>true</code>."
"available (fix spelling) in Chrome and such proxies are widely deployed. As a
result, it will hurt media performance..."

[pthatcher2, 2015-08-28 18:24:00]

https://codereview.chromium.org/1315223002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/preference/preference_api.cc (right):

https://codereview.chromium.org/1315223002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/preference/preference_api.cc:116:
{"webRTCNonProxiedUdpTransportEnabled",
Can we remove "transport" and just say webRTCNonProxiedUdpEnabled?

https://codereview.chromium.org/1315223002/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/privacy.json (right):

https://codereview.chromium.org/1315223002/diff/40001/chrome/common/extension...
chrome/common/extensions/api/privacy.json:28: "description": "If enabled, Chrome
is allowed to use non-proxied UDP transport to connect to peers or TURN servers
when using WebRTC. Since most proxy servers don't handle UDP, using UDP possibly
exposes user's IP address. Turning this off effectively forces WebRTC to only
use TCP for now, until UDP proxy support is available in Chrome and such proxies
are widely deployed. As a result, it also might hurt media performance and
increase the load for proxy servers. This preference's value is a boolean,
defaulting to <code>true</code>."
I'd change

non-proxied UDP transport => non-proxied UDP

[msramek, 2015-08-31 08:54:39]

LGTM with a comment.

https://codereview.chromium.org/1315223002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/preference/preference_api.cc (right):

https://codereview.chromium.org/1315223002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/preference/preference_api.cc:116:
{"webRTCNonProxiedUdpTransportEnabled",
On 2015/08/28 18:24:00, pthatcher2 wrote:
> Can we remove "transport" and just say webRTCNonProxiedUdpEnabled?
> 

+1. I'd prefer a shorter name if possible, and omitting the word "Transport"
doesn't change the meaning.

[guoweis_left_chromium, 2015-08-31 17:09:23]

On 2015/08/31 08:54:39, msramek wrote:
> LGTM with a comment.
> 
>
https://codereview.chromium.org/1315223002/diff/40001/chrome/browser/extensio...
> File chrome/browser/extensions/api/preference/preference_api.cc (right):
> 
>
https://codereview.chromium.org/1315223002/diff/40001/chrome/browser/extensio...
> chrome/browser/extensions/api/preference/preference_api.cc:116:
> {"webRTCNonProxiedUdpTransportEnabled",
> On 2015/08/28 18:24:00, pthatcher2 wrote:
> > Can we remove "transport" and just say webRTCNonProxiedUdpEnabled?
> > 
> 
> +1. I'd prefer a shorter name if possible, and omitting the word "Transport"
> doesn't change the meaning.

PTAL.

[msramek, 2015-08-31 17:23:13]

https://codereview.chromium.org/1315223002/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/api/preference/preference_apitest.cc (right):

https://codereview.chromium.org/1315223002/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/preference/preference_apitest.cc:127:
prefs->SetBoolean(prefs::kWebRTCNonProxiedUdpTransportEnabled, false);
Here too :)

https://codereview.chromium.org/1315223002/diff/60001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/preference/standard/test.js (right):

https://codereview.chromium.org/1315223002/diff/60001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/preference/standard/test.js:47:
'webRTCNonProxiedUdpEnabled'  // requires ENABLE_WEBRTC=1
Nit: formatting.

[guoweis_left_chromium, 2015-08-31 17:46:12]

Patchset #5 (id:80001) has been deleted

[guoweis_left_chromium, 2015-08-31 17:50:27]

brettw@chromium, please look at chrome/browser/extensions/api/preference/* and
chrome/common/extensions/api/privacy.json

[pthatcher2, 2015-08-31 22:25:19]

lgtm, with nit

https://codereview.chromium.org/1315223002/diff/120001/chrome/common/extensio...
File chrome/common/extensions/api/privacy.json (right):

https://codereview.chromium.org/1315223002/diff/120001/chrome/common/extensio...
chrome/common/extensions/api/privacy.json:28: "description": "If enabled, Chrome
is allowed to use non-proxied UDP to connect to peers or TURN servers when using
WebRTC. Since most proxy servers don't handle UDP, using UDP possibly exposes
user's IP address. Turning this off effectively forces WebRTC to only use TCP
for now, until UDP proxy support is available in Chrome and such proxies are
widely deployed. As a result, it also might hurt media performance and increase
the load for proxy servers. This preference's value is a boolean, defaulting to
<code>true</code>."
exposes user's => exposes the users's

[juberti, 2015-08-31 23:23:40]

lgtm

[juberti, 2015-08-31 23:23:42]

lgtm

[guoweis_left_chromium, 2015-09-01 15:08:16]

On 2015/08/31 23:23:42, juberti wrote:
> lgtm

brettw, please look at chrome/browser/extensions/api/preference/* and
chrome/common/extensions/api/privacy.json

[guoweis_left_chromium, 2015-09-01 22:19:54]

guoweis@chromium.org changed reviewers:
- brettw@chromium.org

[guoweis_left_chromium, 2015-09-01 22:21:28]

On 2015/09/01 15:08:16, guoweis_chromium wrote:
> On 2015/08/31 23:23:42, juberti wrote:
> > lgtm
> 
> brettw, please look at chrome/browser/extensions/api/preference/* and
> chrome/common/extensions/api/privacy.json

actually, if you don't mind, I'll go back to patch set #4 and do the renaming in
a different CL. This will make the review easier.

[guoweis_left_chromium, 2015-09-01 22:22:04]

Patchset #6 (id:120001) has been deleted

[guoweis_left_chromium, 2015-09-01 22:22:10]

Patchset #5 (id:100001) has been deleted

[guoweis_left_chromium, 2015-09-01 22:22:53]

On 2015/09/01 22:21:28, guoweis_chromium wrote:
> On 2015/09/01 15:08:16, guoweis_chromium wrote:
> > On 2015/08/31 23:23:42, juberti wrote:
> > > lgtm
> > 
> > brettw, please look at chrome/browser/extensions/api/preference/* and
> > chrome/common/extensions/api/privacy.json
> 
> actually, if you don't mind, I'll go back to patch set #4 and do the renaming
in
> a different CL. This will make the review easier.

kalman, PTAL.

[guoweis_left_chromium, 2015-09-01 22:23:14]

guoweis@chromium.org changed reviewers:
+ kalman@chromium.org

[guoweis_left_chromium, 2015-09-01 22:23:15]

kalman@chromium.org: PTAL.

[guoweis_left_chromium, 2015-09-01 22:31:56]

PTAL. Will remove "transport" in a separate CL.

https://codereview.chromium.org/1315223002/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/api/preference/preference_apitest.cc (right):

https://codereview.chromium.org/1315223002/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/preference/preference_apitest.cc:127:
prefs->SetBoolean(prefs::kWebRTCNonProxiedUdpTransportEnabled, false);
On 2015/08/31 17:23:13, msramek wrote:
> Here too :)

Will rename this in a separate CL as this is much wider used.

https://codereview.chromium.org/1315223002/diff/60001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/preference/standard/test.js (right):

https://codereview.chromium.org/1315223002/diff/60001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/preference/standard/test.js:47:
'webRTCNonProxiedUdpEnabled'  // requires ENABLE_WEBRTC=1
On 2015/08/31 17:23:13, msramek wrote:
> Nit: formatting.

Done.

[not at google - send to devlin, 2015-09-01 22:33:20]

lgtm

[guoweis_left_chromium, 2015-09-01 22:34:31]

The CQ bit was checked by guoweis@chromium.org

[guoweis_left_chromium, 2015-09-01 22:34:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
msramek@chromium.org, juberti@google.com, pthatcher@chromium.org
Link to the patchset: https://codereview.chromium.org/1315223002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-09-01 22:35:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315223002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315223002/140001

[commit-bot: I haz the power, 2015-09-01 23:40:24]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2015-09-01 23:41:11]

Patchset 5 (id:??) landed as
https://crrev.com/be2e0415f2fe42c419ce1660c9acd331f3a174ba
Cr-Commit-Position: refs/heads/master@{#346786}