Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307883002: Add cross origin access check to navigator.serviceWorker. (Closed)

Created:
5 years, 4 months ago by horo
Modified:
5 years, 3 months ago
Reviewers:
kinuko, jww
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, yhirano
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add cross origin access check to navigator.serviceWorker. BUG=522791

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M Source/modules/serviceworkers/NavigatorServiceWorker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 1 1 chunk +5 lines, -1 line 2 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
horo
kinuko@, jww@ Could you please review this?
5 years, 4 months ago (2015-08-21 09:50:10 UTC) #2
horo
I think yhirano@'s patch (https://codereview.chromium.org/1308723003/) is the right way to fix this bug. So, I ...
5 years, 4 months ago (2015-08-21 15:08:13 UTC) #3
jww
https://codereview.chromium.org/1307883002/diff/20001/Source/modules/serviceworkers/NavigatorServiceWorker.cpp File Source/modules/serviceworkers/NavigatorServiceWorker.cpp (right): https://codereview.chromium.org/1307883002/diff/20001/Source/modules/serviceworkers/NavigatorServiceWorker.cpp#newcode60 Source/modules/serviceworkers/NavigatorServiceWorker.cpp:60: exceptionState.throwSecurityError("Access to cross-origin service workers is denied."); Even given ...
5 years, 4 months ago (2015-08-21 18:43:26 UTC) #4
horo
5 years, 3 months ago (2015-09-04 08:24:16 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1307883002/diff/20001/Source/modules/servicew...
File Source/modules/serviceworkers/NavigatorServiceWorker.cpp (right):

https://codereview.chromium.org/1307883002/diff/20001/Source/modules/servicew...
Source/modules/serviceworkers/NavigatorServiceWorker.cpp:60:
exceptionState.throwSecurityError("Access to cross-origin service workers is
denied.");
On 2015/08/21 18:43:26, jww wrote:
> Even given https://codereview.chromium.org/1308723003/, should this be an
ASSERT
> anyway?

Yes, we should so.
Created a CL.
https://codereview.chromium.org/1305903007/

Powered by Google App Engine
This is Rietveld 408576698