Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 1305903007: Add ASSERT() to avoid accidental leaking ServiceWorkerContainer to cross origin context. (Closed)

Created:
5 years, 3 months ago by horo
Modified:
5 years, 2 months ago
Reviewers:
kinuko, jww
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add ASSERT() to avoid accidental leaking ServiceWorkerContainer to cross origin context. BUG=522791 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/modules/serviceworkers/NavigatorServiceWorker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
horo
kinuko@ Could you please review this?
5 years, 3 months ago (2015-09-04 08:24:41 UTC) #2
kinuko
lgtm
5 years, 3 months ago (2015-09-04 13:01:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305903007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305903007/1
5 years, 2 months ago (2015-09-08 01:50:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201889
5 years, 2 months ago (2015-09-08 03:28:05 UTC) #8
jww
5 years, 2 months ago (2015-09-08 16:51:59 UTC) #9
Message was sent while issue was closed.
A belated lgtm (was on vacation, sorry!)

Powered by Google App Engine
This is Rietveld 408576698