Source/web/WebAXObject.cpp - Issue 1307673003: Made CSSPrimitiveValue::getString() only work for String types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebAXObject.cpp

Issue 1307673003: Made CSSPrimitiveValue::getString() only work for String types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_pair

Patch Set: Small fix Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebAXObject.cpp

diff --git a/Source/web/WebAXObject.cpp b/Source/web/WebAXObject.cpp

index 5f4290eca28152645901b9693a0da1910cf717e6..1d313ce7dfc62235315cd95a8797bc47e67d3c2a 100644

--- a/Source/web/WebAXObject.cpp

+++ b/Source/web/WebAXObject.cpp

@@ -31,6 +31,7 @@

#include "config.h"

#include "public/web/WebAXObject.h"

+#include "core/CSSValueKeywords.h"

#include "core/HTMLNames.h"

#include "core/css/CSSPrimitiveValueMappings.h"

#include "core/dom/Document.h"

@@ -1239,7 +1240,7 @@ WebString WebAXObject::computedStyleDisplay() const

if (!computedStyle)

return WebString();

- return WebString(CSSPrimitiveValue::create(computedStyle->display())->getStringValue());

+ return WebString(String(getValueName(CSSPrimitiveValue::create(computedStyle->display())->getValueID())));

Timothy Loh 2015/08/27 01:30:09 ->cssText()?

sashab 2015/08/27 06:30:16 This whole creation of CSSPrimitiveValue isn't act

}

bool WebAXObject::accessibilityIsIgnored() const

« Source/core/css/CSSCounterValue.h ('K') | « Source/core/css/resolver/StyleBuilderCustom.cpp ('k') | no next file » | no next file with comments »