Made CSSPrimitiveValue::getString() only work for String types

Source/web/WebAXObject.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "public/web/WebAXObject.h"
 
+#include "core/CSSValueKeywords.h"
 #include "core/HTMLNames.h"
 #include "core/css/CSSPrimitiveValueMappings.h"
 #include "core/dom/Document.h"
 #include "core/dom/Node.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/VisualViewport.h"
 #include "core/input/EventHandler.h"
 #include "core/layout/LayoutView.h"
 #include "core/style/ComputedStyle.h"
@@ skipping 1188 matching lines @@
         document->updateLayoutTreeIfNeeded();
 
     Node* node = m_private->node();
     if (!node)
         return WebString();
 
     const ComputedStyle* computedStyle = node->ensureComputedStyle();
     if (!computedStyle)
         return WebString();
 
-    return WebString(CSSPrimitiveValue::create(computedStyle->display())->getStringValue());
+    return WebString(String(getValueName(CSSPrimitiveValue::create(computedStyle->display())->getValueID())));

[Timothy Loh, 2015/08/27 01:30:09]

->cssText()?

[sashab, 2015/08/27 06:30:16]

This whole creation of CSSPrimitiveValue isn't actually needed... Maybe what we
need is a toString(platform enum) function.

 }
 
 bool WebAXObject::accessibilityIsIgnored() const
 {
     if (isDetached())
         return false;
 
     return m_private->accessibilityIsIgnored();
 }
 
@@ skipping 360 matching lines @@
     m_private = object;
     return *this;
 }
 
 WebAXObject::operator PassRefPtrWillBeRawPtr<AXObject>() const
 {
     return m_private.get();
 }
 
 } // namespace blink