Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1307663003: Update getUserMedia counts to count Promise API and secure origin use (Closed)

Created:
5 years, 3 months ago by jww
Modified:
5 years, 3 months ago
CC:
blink-reviews, tommyw+watchlist_chromium.org, Henrik Grunell, philipj_slow
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Update getUserMedia counts to count Promise API and secure origin use Previously, only insecure origin use of getUserMedia was counted with RAPPOR. This adds RAPPOR counts for secure origin use. Additionally, this updates the Promise version of the API (still behind a flag) to use all the counts as well. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201433

Patch Set 1 #

Patch Set 2 : Add actual counting of GetUserMedia.Secure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M Source/core/frame/OriginsUsingFeatures.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/frame/OriginsUsingFeatures.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/mediastream/MediaDevices.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/NavigatorMediaStream.cpp View 3 chunks +1 line, -8 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.cpp View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jww
adamk@chromium.org: Please review changes in Source/core/frame/OriginsUsingFeatures.h tommi@chromium.org: Please review changes in Source/modules/mediastream/* Thanks!
5 years, 3 months ago (2015-08-28 16:35:38 UTC) #2
jww
On 2015/08/28 16:35:38, jww wrote: > mailto:adamk@chromium.org: Please review changes in > Source/core/frame/OriginsUsingFeatures.h > > ...
5 years, 3 months ago (2015-08-28 16:39:45 UTC) #3
tommi (sloooow) - chröme
lgtm
5 years, 3 months ago (2015-08-28 16:43:35 UTC) #4
adamk
lgtm for Source/core/
5 years, 3 months ago (2015-08-28 18:46:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307663003/20001
5 years, 3 months ago (2015-08-28 20:50:54 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 22:30:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201433

Powered by Google App Engine
This is Rietveld 408576698