Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Unified Diff: Source/modules/mediastream/NavigatorMediaStream.cpp

Issue 1307663003: Update getUserMedia counts to count Promise API and secure origin use (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add actual counting of GetUserMedia.Secure Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/mediastream/MediaDevices.cpp ('k') | Source/modules/mediastream/UserMediaRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediastream/NavigatorMediaStream.cpp
diff --git a/Source/modules/mediastream/NavigatorMediaStream.cpp b/Source/modules/mediastream/NavigatorMediaStream.cpp
index 40e2450b304ad2ef1f208d0b136a263f17de11a5..7fc0d4ec39ff48940fc02130fb95b531915b2894 100644
--- a/Source/modules/mediastream/NavigatorMediaStream.cpp
+++ b/Source/modules/mediastream/NavigatorMediaStream.cpp
@@ -29,9 +29,7 @@
#include "core/dom/ExceptionCode.h"
#include "core/frame/LocalFrame.h"
#include "core/frame/Navigator.h"
-#include "core/frame/OriginsUsingFeatures.h"
#include "core/frame/Settings.h"
-#include "core/frame/UseCounter.h"
#include "core/page/Page.h"
#include "modules/mediastream/MediaDevicesRequest.h"
#include "modules/mediastream/MediaStreamConstraints.h"
@@ -39,7 +37,6 @@
#include "modules/mediastream/NavigatorUserMediaSuccessCallback.h"
#include "modules/mediastream/UserMediaController.h"
#include "modules/mediastream/UserMediaRequest.h"
-#include "platform/weborigin/SecurityOrigin.h"
namespace blink {
@@ -69,11 +66,7 @@ void NavigatorMediaStream::webkitGetUserMedia(Navigator& navigator, const MediaS
}
String errorMessage;
- if (navigator.frame()->document()->isPrivilegedContext(errorMessage)) {
- UseCounter::count(navigator.frame(), UseCounter::GetUserMediaSecureOrigin);
- } else {
- UseCounter::countDeprecation(navigator.frame(), UseCounter::GetUserMediaInsecureOrigin);
- OriginsUsingFeatures::countAnyWorld(*navigator.frame()->document(), OriginsUsingFeatures::Feature::GetUserMediaInsecureOrigin);
+ if (!request->isPrivilegedContextUse(errorMessage)) {
request->failPermissionDenied(errorMessage);
return;
}
« no previous file with comments | « Source/modules/mediastream/MediaDevices.cpp ('k') | Source/modules/mediastream/UserMediaRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698