Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1307523002: Move nodeIsUserSelectAll() out from PositionAlgorithm template class (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent, hajimehoshi
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move nodeIsUserSelectAll() out from PositionAlgorithm template class This patch moves |nodeIsUserSelectAll()| out from |PositionAlgorithm| template class to "EditingUtilities.cpp" to simplify |PositionAlgorithm| class for improving code health, since |nodeIsUserSelectAll()| doesn't depend on |Strategy| template parameter. BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200882

Patch Set 1 : 2015-08-20T14:22:40 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingUtilities.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/editing/Position.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/Position.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
yosin_UTC9
chromeos_amd64-generic_chromium_compile_only_ng and android_clang_dbg_recipe fail at compile without patch. So, this patch doesn't relate to.
5 years, 4 months ago (2015-08-20 05:52:05 UTC) #2
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-20 05:52:16 UTC) #3
yosin_UTC9
PTAL chromeos_amd64-generic_chromium_compile_only_ng and android_clang_dbg_recipe fail at compile without patch. So, this patch doesn't relate to.
5 years, 4 months ago (2015-08-20 05:52:45 UTC) #4
hajimehoshi
lgtm
5 years, 4 months ago (2015-08-20 06:08:46 UTC) #5
tkent
lgtm
5 years, 4 months ago (2015-08-20 06:14:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307523002/1
5 years, 4 months ago (2015-08-20 06:31:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/110858)
5 years, 4 months ago (2015-08-20 07:18:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307523002/1
5 years, 4 months ago (2015-08-20 07:19:23 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 08:07:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200882

Powered by Google App Engine
This is Rietveld 408576698