Source/core/editing/VisibleUnits.cpp - Issue 1307523002: Move nodeIsUserSelectAll() out from PositionAlgorithm template class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisibleUnits.cpp

Issue 1307523002: Move nodeIsUserSelectAll() out from PositionAlgorithm template class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-20T14:22:40 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/VisibleUnits.cpp

diff --git a/Source/core/editing/VisibleUnits.cpp b/Source/core/editing/VisibleUnits.cpp

index fed0969f7d5879e02880fc2c814399da8de13ade..9f496929064ebe9de17379a0d352200a8c69d28f 100644

--- a/Source/core/editing/VisibleUnits.cpp

+++ b/Source/core/editing/VisibleUnits.cpp

@@ -1143,7 +1143,7 @@ VisiblePosition startOfParagraph(const VisiblePosition& c, EditingBoundaryCrossi

Node* n = startNode;

bool startNodeIsEditable = startNode->hasEditableStyle();

while (n) {

- if (boundaryCrossingRule == CannotCrossEditingBoundary && !Position::nodeIsUserSelectAll(n) && n->hasEditableStyle() != startNodeIsEditable)

+ if (boundaryCrossingRule == CannotCrossEditingBoundary && !nodeIsUserSelectAll(n) && n->hasEditableStyle() != startNodeIsEditable)

break;

if (boundaryCrossingRule == CanSkipOverEditingBoundary) {

while (n && n->hasEditableStyle() != startNodeIsEditable)

@@ -1219,7 +1219,7 @@ VisiblePosition endOfParagraph(const VisiblePosition &c, EditingBoundaryCrossing