Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: Source/bindings/core/v8/V8DOMConfiguration.h

Issue 1307503002: Delete operator= of V8DOMConfiguration structures instead of NONCOPYABLE (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed global-constructors warning Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8DOMConfiguration.h
diff --git a/Source/bindings/core/v8/V8DOMConfiguration.h b/Source/bindings/core/v8/V8DOMConfiguration.h
index 979b78b622f526d56b5366ff1785f9d9f5556b6a..ce95d77deeae3c280105fef88d1795ea88a134c7 100644
--- a/Source/bindings/core/v8/V8DOMConfiguration.h
+++ b/Source/bindings/core/v8/V8DOMConfiguration.h
@@ -66,7 +66,7 @@ public:
// AttributeConfiguration translates into calls to SetAccessor() on either
// the instance or the prototype ObjectTemplate, based on |instanceOrPrototypeConfiguration|.
struct AttributeConfiguration {
- WTF_MAKE_NONCOPYABLE(AttributeConfiguration);
+ AttributeConfiguration& operator=(const AttributeConfiguration&) = delete;
DISALLOW_ALLOCATION();
const char* const name;
v8::AccessorNameGetterCallback getter;
@@ -88,7 +88,7 @@ public:
// AccessorConfiguration translates into calls to SetAccessorProperty()
// on prototype ObjectTemplate.
struct AccessorConfiguration {
- WTF_MAKE_NONCOPYABLE(AccessorConfiguration);
+ AccessorConfiguration& operator=(const AccessorConfiguration&) = delete;
DISALLOW_ALLOCATION();
const char* const name;
v8::FunctionCallback getter;
@@ -123,7 +123,7 @@ public:
// object's constants. It sets the constant on both the FunctionTemplate and
// the ObjectTemplate. PropertyAttributes is always ReadOnly.
struct ConstantConfiguration {
- WTF_MAKE_NONCOPYABLE(ConstantConfiguration);
+ ConstantConfiguration& operator=(const ConstantConfiguration&) = delete;
DISALLOW_ALLOCATION();
const char* const name;
int ivalue;
@@ -150,7 +150,7 @@ public:
// object's callbacks. It sets the method on both the FunctionTemplate or
// the ObjectTemplate.
struct MethodConfiguration {
- WTF_MAKE_NONCOPYABLE(MethodConfiguration);
+ MethodConfiguration& operator=(const MethodConfiguration&) = delete;
DISALLOW_ALLOCATION();
v8::Local<v8::Name> methodName(v8::Isolate* isolate) const { return v8AtomicString(isolate, name); }
v8::FunctionCallback callbackForWorld(const DOMWrapperWorld& world) const
@@ -166,7 +166,7 @@ public:
};
struct SymbolKeyedMethodConfiguration {
- WTF_MAKE_NONCOPYABLE(SymbolKeyedMethodConfiguration);
+ SymbolKeyedMethodConfiguration& operator=(const SymbolKeyedMethodConfiguration&) = delete;
DISALLOW_ALLOCATION();
v8::Local<v8::Name> methodName(v8::Isolate* isolate) const { return getSymbol(isolate); }
v8::FunctionCallback callbackForWorld(const DOMWrapperWorld&) const
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698