Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1307413003: [crankshaft] DCE must not eliminate (observable) math operations. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
CC:
v8-dev, bbudge, rossberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] DCE must not eliminate (observable) math operations. The HUnaryMathOperation cannot be eliminated in general, because the spec requires a ToNumber conversion on the input, which is observable of course. BUG=v8:4389 LOG=y Committed: https://crrev.com/fef38c21e8e119e3bbf5423fd6fc2c03fd1f6c39 Cr-Commit-Position: refs/heads/master@{#30343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -55 lines) Patch
M src/hydrogen-instructions.h View 1 chunk +6 lines, -1 line 0 comments Download
A + test/mjsunit/compiler/regress-4389-1.js View 1 chunk +5 lines, -9 lines 0 comments Download
A + test/mjsunit/compiler/regress-4389-2.js View 1 chunk +5 lines, -9 lines 0 comments Download
A + test/mjsunit/compiler/regress-4389-3.js View 1 chunk +5 lines, -9 lines 0 comments Download
A + test/mjsunit/compiler/regress-4389-4.js View 1 chunk +5 lines, -9 lines 0 comments Download
A + test/mjsunit/compiler/regress-4389-5.js View 1 chunk +5 lines, -9 lines 0 comments Download
A + test/mjsunit/compiler/regress-4389-6.js View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Hannes: PTAL Andreas, Bill: FYI
5 years, 4 months ago (2015-08-25 06:00:48 UTC) #2
Hannes Payer (out of office)
rubber-stamped LGTM
5 years, 4 months ago (2015-08-25 06:04:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307413003/1
5 years, 4 months ago (2015-08-25 06:04:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 06:24:45 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 06:25:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fef38c21e8e119e3bbf5423fd6fc2c03fd1f6c39
Cr-Commit-Position: refs/heads/master@{#30343}

Powered by Google App Engine
This is Rietveld 408576698