Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: src/hydrogen-instructions.h

Issue 1307413003: [crankshaft] DCE must not eliminate (observable) math operations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-4389-1.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_ 5 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_
6 #define V8_HYDROGEN_INSTRUCTIONS_H_ 6 #define V8_HYDROGEN_INSTRUCTIONS_H_
7 7
8 #include <cstring> 8 #include <cstring>
9 #include <iosfwd> 9 #include <iosfwd>
10 10
(...skipping 2617 matching lines...) Expand 10 before | Expand all | Expand 10 after
2628 case kMathPowHalf: 2628 case kMathPowHalf:
2629 set_representation(Representation::Double()); 2629 set_representation(Representation::Double());
2630 break; 2630 break;
2631 default: 2631 default:
2632 UNREACHABLE(); 2632 UNREACHABLE();
2633 } 2633 }
2634 SetFlag(kUseGVN); 2634 SetFlag(kUseGVN);
2635 SetFlag(kAllowUndefinedAsNaN); 2635 SetFlag(kAllowUndefinedAsNaN);
2636 } 2636 }
2637 2637
2638 bool IsDeletable() const override { return true; } 2638 bool IsDeletable() const override {
2639 // TODO(crankshaft): This should be true, however the semantics of this
2640 // instruction also include the ToNumber conversion that is mentioned in the
2641 // spec, which is of course observable.
2642 return false;
2643 }
2639 2644
2640 HValue* SimplifiedDividendForMathFloorOfDiv(HDiv* hdiv); 2645 HValue* SimplifiedDividendForMathFloorOfDiv(HDiv* hdiv);
2641 HValue* SimplifiedDivisorForMathFloorOfDiv(HDiv* hdiv); 2646 HValue* SimplifiedDivisorForMathFloorOfDiv(HDiv* hdiv);
2642 2647
2643 BuiltinFunctionId op_; 2648 BuiltinFunctionId op_;
2644 }; 2649 };
2645 2650
2646 2651
2647 class HLoadRoot final : public HTemplateInstruction<0> { 2652 class HLoadRoot final : public HTemplateInstruction<0> {
2648 public: 2653 public:
(...skipping 5412 matching lines...) Expand 10 before | Expand all | Expand 10 after
8061 }; 8066 };
8062 8067
8063 8068
8064 8069
8065 #undef DECLARE_INSTRUCTION 8070 #undef DECLARE_INSTRUCTION
8066 #undef DECLARE_CONCRETE_INSTRUCTION 8071 #undef DECLARE_CONCRETE_INSTRUCTION
8067 8072
8068 } } // namespace v8::internal 8073 } } // namespace v8::internal
8069 8074
8070 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 8075 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-4389-1.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698