ServiceWorker: Make APIs that return ServiceWorkerRegistration coin a new JS object (2/3)

ServiceWorker: Make APIs that return ServiceWorkerRegistration coin a new JS object (2/3)

The spec requires register/getRegistration/getRegistrations to return a new
registration object, but the current implementation can return existing one.
This CL makes them always coin a new registration object.

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html

(1) Blink: https://codereview.chromium.org/1311113002/
(2) Chromium: THIS PATCH
(3) Blink: https://codereview.chromium.org/1311103002/

BUG=523904
Committed: https://crrev.com/e37a143e2ac4696cbe5f3b058314580ef6c9ee0a
Cr-Commit-Position: refs/heads/master@{#345277}

[nhiroki, 2015-08-24 10:25:47]

Patchset #1 (id:1) has been deleted

[nhiroki, 2015-08-24 11:00:30]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2015-08-24 11:03:02]

Patchset #1 (id:40001) has been deleted

[nhiroki, 2015-08-25 01:47:05]

Patchset #1 (id:60001) has been deleted

[nhiroki, 2015-08-25 01:49:47]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org

[nhiroki, 2015-08-25 01:49:53]

PTAL

[falken, 2015-08-25 03:26:45]

lgtm, looks a lot simpler

https://codereview.chromium.org/1307133003/diff/80001/content/child/service_w...
File content/child/service_worker/service_worker_dispatcher.h (right):

https://codereview.chromium.org/1307133003/diff/80001/content/child/service_w...
content/child/service_worker/service_worker_dispatcher.h:140:
scoped_ptr<WebServiceWorkerRegistrationImpl> CreateRegistration(
Have you considered splitting this into CreateRegistration and AdoptRegistration
so we can eliminate the bool param? Similar to how
ServiceWorkerRegistrationHandleReference has Adopt and Create.

[nhiroki, 2015-08-25 05:40:54]

Thank you! Updated.

https://codereview.chromium.org/1307133003/diff/80001/content/child/service_w...
File content/child/service_worker/service_worker_dispatcher.h (right):

https://codereview.chromium.org/1307133003/diff/80001/content/child/service_w...
content/child/service_worker/service_worker_dispatcher.h:140:
scoped_ptr<WebServiceWorkerRegistrationImpl> CreateRegistration(
On 2015/08/25 03:26:45, falken wrote:
> Have you considered splitting this into CreateRegistration and
AdoptRegistration
> so we can eliminate the bool param? Similar to how
> ServiceWorkerRegistrationHandleReference has Adopt and Create.

Good. Done. I'll do the same cleanup for GetServiceWorker in a separate patch.

[nhiroki, 2015-08-25 05:41:01]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2015-08-25 05:41:01]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1307133003/#ps100001
(title: "split CreateRegistration()")

[commit-bot: I haz the power, 2015-08-25 05:41:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307133003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307133003/100001

[commit-bot: I haz the power, 2015-08-25 06:32:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 06:32:07]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nhiroki, 2015-08-25 06:32:56]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2015-08-25 06:33:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307133003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307133003/100001

[commit-bot: I haz the power, 2015-08-25 07:02:39]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2015-08-25 07:03:26]

Patchset 2 (id:??) landed as
https://crrev.com/e37a143e2ac4696cbe5f3b058314580ef6c9ee0a
Cr-Commit-Position: refs/heads/master@{#345277}