Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1307133003: ServiceWorker: Make APIs that return ServiceWorkerRegistration coin a new JS object (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: split CreateRegistration() Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/service_worker/service_worker_dispatcher_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 55cf381ce034c50eb5c4d170f7a106005cfd49cb..de57d4ce2afe15b41ccd6e2fe73f9b2ed3a1d0c2 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -677,14 +677,7 @@ void ServiceWorkerContextClient::SetRegistrationInServiceWorkerGlobalScope() {
// Register a registration and its version attributes with the dispatcher
// living on the worker thread.
scoped_ptr<WebServiceWorkerRegistrationImpl> registration(
- dispatcher->CreateServiceWorkerRegistration(info, false));
- registration->SetInstalling(
- dispatcher->GetServiceWorker(attrs.installing, false));
- registration->SetWaiting(
- dispatcher->GetServiceWorker(attrs.waiting, false));
- registration->SetActive(
- dispatcher->GetServiceWorker(attrs.active, false));
-
+ dispatcher->CreateRegistration(info, attrs));
proxy_->setRegistration(registration.release());
}
« no previous file with comments | « content/child/service_worker/service_worker_dispatcher_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698