Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1307093006: Spliting out TyperCache into ZoneTypeCache to share with AsmTyper. (Closed)

Created:
5 years, 3 months ago by bradn
Modified:
5 years, 3 months ago
Reviewers:
titzer, andreas
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Spliting out TyperCache into ZoneTypeCache to share with AsmTyper. The zone type cache would be handy inside the asm.js typer. Pulling it out into a seperate inlinable header to allow sharing. BUG=https://code.google.com/p/v8/issues/detail?id=4203 TEST=None R=andreas@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/e2b3edbf31a57023414f355f3b6ecbaa5689745f Cr-Commit-Position: refs/heads/master@{#30398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -86 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +2 lines, -83 lines 0 comments Download
A src/zone-type-cache.h View 1 chunk +98 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
bradn
5 years, 3 months ago (2015-08-26 17:41:56 UTC) #1
titzer
lgtm
5 years, 3 months ago (2015-08-26 21:27:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307093006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307093006/1
5 years, 3 months ago (2015-08-26 21:39:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 21:40:56 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 21:41:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2b3edbf31a57023414f355f3b6ecbaa5689745f
Cr-Commit-Position: refs/heads/master@{#30398}

Powered by Google App Engine
This is Rietveld 408576698