Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: src/compiler/typer.cc

Issue 1307093006: Spliting out TyperCache into ZoneTypeCache to share with AsmTyper. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.h ('k') | src/zone-type-cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index aabcf4b5a8fd71f192918160dc6987502dac3638..40353f559c480477fe6f26a8e90ef8c9ad9ac666 100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -13,96 +13,15 @@
#include "src/compiler/node.h"
#include "src/compiler/node-properties.h"
#include "src/compiler/simplified-operator.h"
+#include "src/zone-type-cache.h"
namespace v8 {
namespace internal {
namespace compiler {
-class TyperCache final {
- private:
- // This has to be first for the initialization magic to work.
- Zone zone_;
-
- public:
- TyperCache() = default;
-
- Type* const kInt8 =
- CreateNative(CreateRange<int8_t>(), Type::UntaggedSigned8());
- Type* const kUint8 =
- CreateNative(CreateRange<uint8_t>(), Type::UntaggedUnsigned8());
- Type* const kUint8Clamped = kUint8;
- Type* const kInt16 =
- CreateNative(CreateRange<int16_t>(), Type::UntaggedSigned16());
- Type* const kUint16 =
- CreateNative(CreateRange<uint16_t>(), Type::UntaggedUnsigned16());
- Type* const kInt32 = CreateNative(Type::Signed32(), Type::UntaggedSigned32());
- Type* const kUint32 =
- CreateNative(Type::Unsigned32(), Type::UntaggedUnsigned32());
- Type* const kFloat32 = CreateNative(Type::Number(), Type::UntaggedFloat32());
- Type* const kFloat64 = CreateNative(Type::Number(), Type::UntaggedFloat64());
-
- Type* const kSingletonZero = CreateRange(0.0, 0.0);
- Type* const kSingletonOne = CreateRange(1.0, 1.0);
- Type* const kZeroOrOne = CreateRange(0.0, 1.0);
- Type* const kZeroish =
- Type::Union(kSingletonZero, Type::MinusZeroOrNaN(), zone());
- Type* const kInteger = CreateRange(-V8_INFINITY, V8_INFINITY);
- Type* const kWeakint = Type::Union(kInteger, Type::MinusZeroOrNaN(), zone());
- Type* const kWeakintFunc1 = Type::Function(kWeakint, Type::Number(), zone());
-
- Type* const kRandomFunc0 = Type::Function(Type::OrderedNumber(), zone());
- Type* const kAnyFunc0 = Type::Function(Type::Any(), zone());
- Type* const kAnyFunc1 = Type::Function(Type::Any(), Type::Any(), zone());
- Type* const kAnyFunc2 =
- Type::Function(Type::Any(), Type::Any(), Type::Any(), zone());
- Type* const kAnyFunc3 = Type::Function(Type::Any(), Type::Any(), Type::Any(),
- Type::Any(), zone());
- Type* const kNumberFunc0 = Type::Function(Type::Number(), zone());
- Type* const kNumberFunc1 =
- Type::Function(Type::Number(), Type::Number(), zone());
- Type* const kNumberFunc2 =
- Type::Function(Type::Number(), Type::Number(), Type::Number(), zone());
- Type* const kImulFunc = Type::Function(Type::Signed32(), Type::Integral32(),
- Type::Integral32(), zone());
- Type* const kClz32Func =
- Type::Function(CreateRange(0, 32), Type::Number(), zone());
-
-#define TYPED_ARRAY(TypeName, type_name, TYPE_NAME, ctype, size) \
- Type* const k##TypeName##Array = CreateArray(k##TypeName);
- TYPED_ARRAYS(TYPED_ARRAY)
-#undef TYPED_ARRAY
-
- private:
- Type* CreateArray(Type* element) { return Type::Array(element, zone()); }
-
- Type* CreateArrayFunction(Type* array) {
- Type* arg1 = Type::Union(Type::Unsigned32(), Type::Object(), zone());
- Type* arg2 = Type::Union(Type::Unsigned32(), Type::Undefined(), zone());
- Type* arg3 = arg2;
- return Type::Function(array, arg1, arg2, arg3, zone());
- }
-
- Type* CreateNative(Type* semantic, Type* representation) {
- return Type::Intersect(semantic, representation, zone());
- }
-
- template <typename T>
- Type* CreateRange() {
- return CreateRange(std::numeric_limits<T>::min(),
- std::numeric_limits<T>::max());
- }
-
- Type* CreateRange(double min, double max) {
- return Type::Range(min, max, zone());
- }
-
- Zone* zone() { return &zone_; }
-};
-
-
namespace {
-base::LazyInstance<TyperCache>::type kCache = LAZY_INSTANCE_INITIALIZER;
+base::LazyInstance<ZoneTypeCache>::type kCache = LAZY_INSTANCE_INITIALIZER;
} // namespace
« no previous file with comments | « src/compiler/typer.h ('k') | src/zone-type-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698