content/browser/devtools/devtools_agent_host_impl.cc - Issue 1307073002: DevTools: provide an option to return traces as streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_agent_host_impl.cc

Issue 1307073002: DevTools: provide an option to return traces as streams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/devtools_agent_host_impl.h ('K') | « content/browser/devtools/devtools_agent_host_impl.h ('k') | content/browser/devtools/devtools_io_context.h » ('j') | content/browser/devtools/devtools_io_context.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_agent_host_impl.cc

diff --git a/content/browser/devtools/devtools_agent_host_impl.cc b/content/browser/devtools/devtools_agent_host_impl.cc

index cfe65e59cd2c4e577489f9f985714c9c7167cec3..0a03bd2e43ec0e1bc841282a8d312691778d8a0b 100644

--- a/content/browser/devtools/devtools_agent_host_impl.cc

+++ b/content/browser/devtools/devtools_agent_host_impl.cc

@@ -109,6 +109,7 @@ void DevToolsAgentHostImpl::AttachClient(DevToolsAgentHostClient* client) {

if (client_) {

client_->AgentHostClosed(this, true);

Detach();

+ io_context_.DiscardAllStreams();

pfeldman 2015/08/24 18:17:55 You are calling it from 2(3) places. Introduce Inn

}

client_ = client;

Attach();

@@ -121,6 +122,7 @@ void DevToolsAgentHostImpl::DetachClient() {

scoped_refptr<DevToolsAgentHostImpl> protect(this);

client_ = NULL;

Detach();

+ io_context_.DiscardAllStreams();

}

bool DevToolsAgentHostImpl::IsAttached() {