DevTools: provide an option to return traces as streams

content/browser/devtools/devtools_agent_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/devtools_agent_host_impl.h"
 
 #include <map>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 91 matching lines @@
 scoped_refptr<DevToolsAgentHost> DevToolsAgentHost::Create(
     DevToolsExternalAgentProxyDelegate* delegate) {
   return new ForwardingAgentHost(delegate);
 }
 
 void DevToolsAgentHostImpl::AttachClient(DevToolsAgentHostClient* client) {
   scoped_refptr<DevToolsAgentHostImpl> protect(this);
   if (client_) {
     client_->AgentHostClosed(this, true);
     Detach();
+    io_context_.DiscardAllStreams();

[pfeldman, 2015/08/24 18:17:55]

You are calling it from 2(3) places. Introduce InnerDetach() ?

   }
   client_ = client;
   Attach();
 }
 
 void DevToolsAgentHostImpl::DetachClient() {
   if (!client_)
     return;
 
   scoped_refptr<DevToolsAgentHostImpl> protect(this);
   client_ = NULL;
   Detach();
+  io_context_.DiscardAllStreams();
 }
 
 bool DevToolsAgentHostImpl::IsAttached() {
   return !!client_;
 }
 
 void DevToolsAgentHostImpl::InspectElement(int x, int y) {
 }
 
 std::string DevToolsAgentHostImpl::GetId() {
@@ skipping 126 matching lines @@
 
   if (chunk.is_last) {
     CHECK(message_buffer_.size() == message_buffer_size_);
     callback_.Run(message_buffer_);
     message_buffer_ = std::string();
     message_buffer_size_ = 0;
   }
 }
 
 }  // namespace content