Issue 130693002: Revert 243714 "Update GPU feature tests to expect no GPU on Wind..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130693002: Revert 243714 "Update GPU feature tests to expect no GPU on Wind..." (Closed)

Created:
6 years, 11 months ago by scottmg

Modified:
6 years, 11 months ago

Reviewers:
ccameron

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 243714 "Update GPU feature tests to expect no GPU on Wind..." Failing on main waterfall Vista Tests (1): [ RUN ] GpuFeatureTest.MultisamplingAllowed [4884:2868:0108/183111:2787078:ERROR:desktop_root_window_host_win.cc(757)] NOT IMPLEMENTED test\gpu\gpu_feature_browsertest.cc(305): error: Value of: GpuDataManager::GetInstance()->IsFeatureBlacklisted( gpu::GPU_FEATURE_TYPE_MULTISAMPLING) Actual: true Expected: expect_blacklisted Which is: false > Update GPU feature tests to expect no GPU on Windows <=Vista > > BUG=243476 > > Review URL: https://codereview.chromium.org/128893002 TBR=ccameron@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243749

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -9 lines)			Patch
	M	trunk/src/chrome/test/gpu/gpu_feature_browsertest.cc	View		3 chunks	+20 lines, -2 lines	0 comments	Download
	M	trunk/src/gpu/config/gpu_test_config.cc	View		2 chunks	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r243749.

Expand Messages | Collapse Messages