Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 128893002: Update GPU feature tests to expect no GPU on Windows <=Vista (Closed)

Created:
6 years, 11 months ago by ccameron
Modified:
6 years, 11 months ago
Reviewers:
zmo, Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Update GPU feature tests to expect no GPU on Windows <=Vista BUG=243476 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243714

Patch Set 1 #

Total comments: 2

Patch Set 2 : Try again after 500s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
chrome/test/gpu/gpu_feature_browsertest.cc View 1 3 chunks +2 lines, -20 lines 0 comments Download
gpu/config/gpu_test_config.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
ccameron
My patch yesterday blew up these tests & they were disabled. This updates their expectations ...
6 years, 11 months ago (2014-01-08 18:28:44 UTC) #1
Zhenyao Mo
nice cleanup LGTM https://codereview.chromium.org/128893002/diff/1/gpu/config/gpu_test_config.cc File gpu/config/gpu_test_config.cc (right): https://codereview.chromium.org/128893002/diff/1/gpu/config/gpu_test_config.cc#newcode283 gpu/config/gpu_test_config.cc:283: #if defined(OS_MACOSX) nit: this should be ...
6 years, 11 months ago (2014-01-08 19:12:10 UTC) #2
ccameron
Thanks!! https://codereview.chromium.org/128893002/diff/1/gpu/config/gpu_test_config.cc File gpu/config/gpu_test_config.cc (right): https://codereview.chromium.org/128893002/diff/1/gpu/config/gpu_test_config.cc#newcode283 gpu/config/gpu_test_config.cc:283: #if defined(OS_MACOSX) On 2014/01/08 19:12:11, Zhenyao Mo wrote: ...
6 years, 11 months ago (2014-01-08 19:44:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/128893002/60001
6 years, 11 months ago (2014-01-08 19:49:21 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 11 months ago (2014-01-08 20:26:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/128893002/380001
6 years, 11 months ago (2014-01-08 20:56:34 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243628
6 years, 11 months ago (2014-01-08 22:37:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/128893002/380001
6 years, 11 months ago (2014-01-08 22:47:28 UTC) #8
commit-bot: I haz the power
Change committed as 243714
6 years, 11 months ago (2014-01-09 00:48:34 UTC) #9
Luigi Semenzato
On 2014/01/09 00:48:34, I haz the power (commit-bot) wrote: > Change committed as 243714 Would ...
6 years, 11 months ago (2014-01-09 01:10:15 UTC) #10
ccameron
6 years, 11 months ago (2014-01-09 08:25:44 UTC) #11
Message was sent while issue was closed.
On 2014/01/09 01:10:15, Luigi Semenzato wrote:
> On 2014/01/09 00:48:34, I haz the power (commit-bot) wrote:
> > Change committed as 243714
> 
> Would you be so kind to check the bug number on this?  I think you have the
> wrong one.  Thanks!

This should be crbug.com/327430 ... I think that a revision number and bug
number got swapped by accident.

Powered by Google App Engine
This is Rietveld 408576698