Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 1306743002: [Editing][Codehealth] Replace Position::uptream/downstream to mostBackward/ForwardCaretPosition. (Closed)

Created:
5 years, 4 months ago by yoichio
Modified:
5 years, 4 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Editing][Codehealth] Replace Position::uptream/downstream to mostBackward/ForwardCaretPosition Position::upstream calls just VisibleUnit.cpp::mostForwardCaretPosition and also downstream: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/c ore/editing/Position.cpp&l=484&cl=GROK This CL replaces it. We will replace all upstream/downstream and remove them. BUG=518738 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/layout/HitTestResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yosin_UTC9
lgtm +tkent@ for OWNERS.
5 years, 4 months ago (2015-08-21 07:18:59 UTC) #3
tkent
lgtm
5 years, 4 months ago (2015-08-21 07:58:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306743002/1
5 years, 4 months ago (2015-08-21 08:01:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200977
5 years, 4 months ago (2015-08-21 09:31:24 UTC) #7
yoichio
5 years, 4 months ago (2015-08-21 10:10:54 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1304133002/ by yoichio@chromium.org.

The reason for reverting is: This patch misused each other.
See:
 https://codereview.chromium.org/1310433004/.

Powered by Google App Engine
This is Rietveld 408576698