Source/core/layout/HitTestResult.cpp - Issue 1306743002: [Editing][Codehealth] Replace Position::uptream/downstream to mostBackward/ForwardCaretPosition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/HitTestResult.cpp

Issue 1306743002: [Editing][Codehealth] Replace Position::uptream/downstream to mostBackward/ForwardCaretPosition. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/HitTestResult.cpp

diff --git a/Source/core/layout/HitTestResult.cpp b/Source/core/layout/HitTestResult.cpp

index 09d078958707690cfcc7df7186ef71d2e8206a1c..2473a083c48beca7a111ad089a700b10d895d2fd 100644

--- a/Source/core/layout/HitTestResult.cpp

+++ b/Source/core/layout/HitTestResult.cpp

@@ -163,7 +163,7 @@ PositionWithAffinity HitTestResult::position() const

if (!layoutObject)

return PositionWithAffinity();

if (m_innerPossiblyPseudoNode->isPseudoElement() && m_innerPossiblyPseudoNode->pseudoId() == BEFORE)

- return Position(m_innerNode, PositionAnchorType::BeforeChildren).downstream();

+ return mostBackwardCaretPosition(Position(m_innerNode, PositionAnchorType::BeforeChildren));

return layoutObject->positionForPoint(localPoint());

}

« no previous file with comments | « no previous file | Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »