Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1306733006: Revert of WKWebView: Added cert verification API to web controller. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of WKWebView: Added cert verification API to web controller. (patchset #26 id:490001 of https://codereview.chromium.org/1230033005/ ) Reason for revert: Compile failed ios/web/net/cert_verifier_block_adapter.cc:28:26: error: no member named 'SOURCE_IOS_WEB_VIEW_CERT_VERIFIER' in 'net::NetLog' Original issue's description: > WKWebView: Added cert verification API to web controller. > > This code is just a skeleton for verification and verification method > is not used for making security decisions or presenting security UI. > > The decision to use CertVerifier instead of iOS cert verification API > has not been made yet. But using CertVerifier is easier for > -[WKWebView certificateChain] verification, so this CL uses > CertVerifier. > > BUG=462427, 462425 > > Committed: https://crrev.com/dc5f11025e1db3b7766bf5faeacc316969b519b2 > Cr-Commit-Position: refs/heads/master@{#347302} TBR=rsleevi@chromium.org,stuartmorgan@chromium.org,davidben@chromium.org,eugenebut@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462427, 462425 Committed: https://crrev.com/bd6ed3f209bb72148118a118d9d176a1912df178 Cr-Commit-Position: refs/heads/master@{#347304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -630 lines) Patch
M ios/web/ios_web.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/ios_web_unittests.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/web/net/cert_verifier_block_adapter.h View 2 chunks +26 lines, -39 lines 0 comments Download
M ios/web/net/cert_verifier_block_adapter.cc View 1 chunk +47 lines, -57 lines 0 comments Download
M ios/web/net/cert_verifier_block_adapter_unittest.cc View 2 chunks +169 lines, -114 lines 0 comments Download
D ios/web/net/crw_cert_verification_controller.h View 1 chunk +0 lines, -68 lines 0 comments Download
D ios/web/net/crw_cert_verification_controller.mm View 1 chunk +0 lines, -194 lines 0 comments Download
D ios/web/net/crw_cert_verification_controller_unittest.mm View 1 chunk +0 lines, -114 lines 0 comments Download
M ios/web/public/test/test_browser_state.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 5 chunks +3 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of WKWebView: Added cert verification API to web controller.
5 years, 3 months ago (2015-09-04 02:24:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306733006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306733006/1
5 years, 3 months ago (2015-09-04 02:25:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 02:26:16 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 02:27:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd6ed3f209bb72148118a118d9d176a1912df178
Cr-Commit-Position: refs/heads/master@{#347304}

Powered by Google App Engine
This is Rietveld 408576698