Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1306683007: Permissions API: remove deprecated PermissionStatus.status. (Closed)

Created:
5 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 3 months ago
Reviewers:
dcheng
CC:
blink-reviews, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Permissions API: remove deprecated PermissionStatus.status. It has been deprecated a few months ago and it's usage is near 0. Deprecation CL: https://codereview.chromium.org/1194963002 Counter: https://www.chromestatus.com/metrics/feature/timeline/popularity/852 BUG=502275 Committed: https://crrev.com/d2b8b043107ea786d3915f2f20fcb43b5391ef20 git-svn-id: svn://svn.chromium.org/blink/trunk@202012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : tests #

Patch Set 3 : moar test updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M LayoutTests/http/tests/permissions/resources/test-query.js View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/permissions/PermissionStatus.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mlamouri (slow - plz ping)
5 years, 3 months ago (2015-09-09 13:53:52 UTC) #2
dcheng
lgtm
5 years, 3 months ago (2015-09-09 22:14:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306683007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306683007/40001
5 years, 3 months ago (2015-09-09 23:08:44 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202012
5 years, 3 months ago (2015-09-10 00:28:03 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:05:22 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d2b8b043107ea786d3915f2f20fcb43b5391ef20

Powered by Google App Engine
This is Rietveld 408576698