Add PermissionStatus.state and deprecate PermissionStatus.status.

Add PermissionStatus.state and deprecate PermissionStatus.status.

This is following the specification change:
https://github.com/w3c/permissions/issues/31

BUG=502275
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198047

[mlamouri (slow - plz ping), 2015-06-19 16:01:38]

mlamouri@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2015-06-22 10:42:46]

LGTM with a couple of long term suggestions and questions

https://codereview.chromium.org/1194963002/diff/1/LayoutTests/http/tests/perm...
File LayoutTests/http/tests/permissions/chromium/resources/test-change-event.js
(left):

https://codereview.chromium.org/1194963002/diff/1/LayoutTests/http/tests/perm...
LayoutTests/http/tests/permissions/chromium/resources/test-change-event.js:14:
assert_equals(p.status, 'granted');
Don't you want to make sure the deprecated but not removed yet property still
works?

https://codereview.chromium.org/1194963002/diff/1/Source/modules/permissions/...
File Source/modules/permissions/PermissionStatus.cpp (right):

https://codereview.chromium.org/1194963002/diff/1/Source/modules/permissions/...
Source/modules/permissions/PermissionStatus.cpp:156: if
(executionContext()->isWorkerGlobalScope()) {
This sounds like a good candidate for
ExecutionContext::addConsoleMessage(message) method

https://codereview.chromium.org/1194963002/diff/1/Source/modules/permissions/...
File Source/modules/permissions/PermissionStatus.idl (right):

https://codereview.chromium.org/1194963002/diff/1/Source/modules/permissions/...
Source/modules/permissions/PermissionStatus.idl:22: readonly attribute
PermissionState status;
Mark as Deprecated and make it print the message automatically?

[mlamouri (slow - plz ping), 2015-06-29 19:26:06]

https://codereview.chromium.org/1194963002/diff/1/LayoutTests/http/tests/perm...
File LayoutTests/http/tests/permissions/chromium/resources/test-change-event.js
(left):

https://codereview.chromium.org/1194963002/diff/1/LayoutTests/http/tests/perm...
LayoutTests/http/tests/permissions/chromium/resources/test-change-event.js:14:
assert_equals(p.status, 'granted');
On 2015/06/22 at 10:42:46, whywhat wrote:
> Don't you want to make sure the deprecated but not removed yet property still
works?

Given that the code is simplistic: just calling state(), I think it's not worth
the overhead.

https://codereview.chromium.org/1194963002/diff/1/Source/modules/permissions/...
File Source/modules/permissions/PermissionStatus.cpp (right):

https://codereview.chromium.org/1194963002/diff/1/Source/modules/permissions/...
Source/modules/permissions/PermissionStatus.cpp:156: if
(executionContext()->isWorkerGlobalScope()) {
On 2015/06/22 at 10:42:46, whywhat wrote:
> This sounds like a good candidate for
ExecutionContext::addConsoleMessage(message) method

Will do.

https://codereview.chromium.org/1194963002/diff/1/Source/modules/permissions/...
File Source/modules/permissions/PermissionStatus.idl (right):

https://codereview.chromium.org/1194963002/diff/1/Source/modules/permissions/...
Source/modules/permissions/PermissionStatus.idl:22: readonly attribute
PermissionState status;
On 2015/06/22 at 10:42:46, whywhat wrote:
> Mark as Deprecated and make it print the message automatically?

It wouldn't show up in Workers :(

[mlamouri (slow - plz ping), 2015-06-29 19:26:09]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-06-29 19:26:09]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/1194963002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-29 19:26:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1194963002/20001

[mlamouri (slow - plz ping), 2015-06-29 19:29:22]

The CQ bit was unchecked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-06-29 19:35:21]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-06-29 19:35:22]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/1194963002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-06-29 19:35:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1194963002/60001

[mlamouri (slow - plz ping), 2015-06-29 19:38:09]

The CQ bit was unchecked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-06-29 19:51:17]

https://codereview.chromium.org/1194963002/diff/1/Source/modules/permissions/...
File Source/modules/permissions/PermissionStatus.idl (right):

https://codereview.chromium.org/1194963002/diff/1/Source/modules/permissions/...
Source/modules/permissions/PermissionStatus.idl:22: readonly attribute
PermissionState status;
On 2015/06/29 at 19:26:06, Mounir Lamouri wrote:
> On 2015/06/22 at 10:42:46, whywhat wrote:
> > Mark as Deprecated and make it print the message automatically?
> 
> It wouldn't show up in Workers :(

Actually, it will... I don't know how I came to that conclusion.

[mlamouri (slow - plz ping), 2015-06-29 19:52:00]

mlamouri@chromium.org changed reviewers:
+ dcheng@chromium.org

[mlamouri (slow - plz ping), 2015-06-29 19:52:01]

+dcheng@ for UseCounter.* changes.

[dcheng, 2015-06-29 21:07:17]

rs lgtm for UseCounter.* change

[mlamouri (slow - plz ping), 2015-06-30 09:16:09]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-06-30 09:16:09]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/1194963002/#ps80001
(title: "use DeprecateAs")

[commit-bot: I haz the power, 2015-06-30 09:16:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1194963002/80001

[commit-bot: I haz the power, 2015-06-30 10:40:27]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198047