chrome/chrome_watcher/chrome_watcher_main.cc - Issue 1306603003: Redefine CreateFileVersionInfoForCurrentModule() as a macro on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_watcher/chrome_watcher_main.cc

Issue 1306603003: Redefine CreateFileVersionInfoForCurrentModule() as a macro on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use a real macro Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_watcher/chrome_watcher_main.cc

diff --git a/chrome/chrome_watcher/chrome_watcher_main.cc b/chrome/chrome_watcher/chrome_watcher_main.cc

index 7d9c6db655eafcccfb745b1d7c98470fcdbf3b2c..6219bec68d30d609699879a9ea7c043dda294e2d 100644

--- a/chrome/chrome_watcher/chrome_watcher_main.cc

+++ b/chrome/chrome_watcher/chrome_watcher_main.cc

@@ -244,8 +244,7 @@ void DumpHungBrowserProcess(DWORD main_thread_id,

// This is looking up the version of chrome_watcher.dll, which is equivalent

// for our purposes to chrome.dll.

scoped_ptr<FileVersionInfo> version_info(

- FileVersionInfo::CreateFileVersionInfoForModule(

- reinterpret_cast<HMODULE>(&__ImageBase)));

+ CREATE_FILE_VERSION_INFO_FOR_CURRENT_MODULE());

using CrashKeyStrings = std::pair<base::string16, base::string16>;

std::vector<CrashKeyStrings> crash_key_strings;

if (version_info.get()) {

« no previous file with comments | « chrome/app/client_util.cc ('k') | cloud_print/common/win/install_utils.cc » ('j') | no next file with comments »