Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: net/base/network_change_notifier.h

Issue 1306423004: [NetInfo] Browser changes to support connection.downlinkMax (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: No millibits for you! Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/network_change_notifier.h
diff --git a/net/base/network_change_notifier.h b/net/base/network_change_notifier.h
index 8206e3911776efe4a36ff65360db09b2b4b77667..4f8cdb1276f342bb3b8396c0a8b41ab07f0ae62b 100644
--- a/net/base/network_change_notifier.h
+++ b/net/base/network_change_notifier.h
@@ -243,6 +243,11 @@ class NET_EXPORT NetworkChangeNotifier {
static void GetMaxBandwidthAndConnectionType(double* max_bandwidth_mbps,
ConnectionType* connection_type);
+ // Returns a theoretical upper limit (in Mbps) on download bandwidth given a
+ // connection subtype. The mapping of connection type to maximum bandwidth is
+ // provided in the NetInfo spec: http://w3c.github.io/netinfo/.
+ static double GetMaxBandwidthForConnectionSubtype(ConnectionSubtype subtype);
jochen (gone - plz use gerrit) 2015/09/16 11:26:18 What about adding the unit (Mbps) to the function
jkarlin 2015/09/16 12:09:36 Good idea, but in a different CL. This is a pre-ex
+
// Retrieve the last read DnsConfig. This could be expensive if the system has
// a large HOSTS file.
static void GetDnsConfig(DnsConfig* config);
@@ -399,11 +404,6 @@ class NET_EXPORT NetworkChangeNotifier {
double* max_bandwidth_mbps,
ConnectionType* connection_type) const;
- // Returns a theoretical upper limit on download bandwidth given a connection
- // subtype. The mapping of connection type to maximum bandwidth is provided in
- // the NetInfo spec: http://w3c.github.io/netinfo/.
- static double GetMaxBandwidthForConnectionSubtype(ConnectionSubtype subtype);
-
// Broadcasts a notification to all registered observers. Note that this
// happens asynchronously, even for observers on the current thread, even in
// tests.

Powered by Google App Engine
This is Rietveld 408576698