[NetInfo] Browser changes to support connection.downlinkMax

net/base/network_change_notifier.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NETWORK_CHANGE_NOTIFIER_H_
 #define NET_BASE_NETWORK_CHANGE_NOTIFIER_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 225 matching lines @@
   // bandwidth, potentially based on underlying connection type, signal
   // strength, or some other signal. Specifically, it returns +Infinity if there
   // is a connection and 0.0 otherwise. The circumstances in which a more
   // specific value is given are:  Android cellular types, Android wifi types,
   // and ChromeOS cellular types. See the NetInfo spec for the mapping of
   // specific subtypes to bandwidth values: http://w3c.github.io/netinfo/.
   // |connection_type| is set to the current ConnectionType.
   static void GetMaxBandwidthAndConnectionType(double* max_bandwidth_mbps,
                                                ConnectionType* connection_type);
 
+  // Returns a theoretical upper limit (in Mbps) on download bandwidth given a
+  // connection subtype. The mapping of connection type to maximum bandwidth is
+  // provided in the NetInfo spec: http://w3c.github.io/netinfo/.
+  static double GetMaxBandwidthForConnectionSubtype(ConnectionSubtype subtype);

[jochen (gone - plz use gerrit), 2015/09/16 11:26:18]

What about adding the unit (Mbps) to the function name?

[jkarlin, 2015/09/16 12:09:36]

Good idea, but in a different CL. This is a pre-existing function that I made
public in this CL. TODO added.

+
   // Retrieve the last read DnsConfig. This could be expensive if the system has
   // a large HOSTS file.
   static void GetDnsConfig(DnsConfig* config);
 
 #if defined(OS_LINUX)
   // Returns the AddressTrackerLinux if present.
   static const internal::AddressTrackerLinux* GetAddressTracker();
 #endif
 
   // Convenience method to determine if the user is offline.
@@ skipping 136 matching lines @@
       GetAddressTrackerInternal() const;
 #endif
 
   // See the description of NetworkChangeNotifier::GetMaxBandwidth().
   // Implementations must be thread-safe. Implementations must also be
   // cheap as it is called often.
   virtual void GetCurrentMaxBandwidthAndConnectionType(
       double* max_bandwidth_mbps,
       ConnectionType* connection_type) const;
 
-  // Returns a theoretical upper limit on download bandwidth given a connection
-  // subtype. The mapping of connection type to maximum bandwidth is provided in
-  // the NetInfo spec: http://w3c.github.io/netinfo/.
-  static double GetMaxBandwidthForConnectionSubtype(ConnectionSubtype subtype);
-
   // Broadcasts a notification to all registered observers.  Note that this
   // happens asynchronously, even for observers on the current thread, even in
   // tests.
   static void NotifyObserversOfIPAddressChange();
   static void NotifyObserversOfConnectionTypeChange();
   static void NotifyObserversOfDNSChange();
   static void NotifyObserversOfInitialDNSConfigRead();
   static void NotifyObserversOfNetworkChange(ConnectionType type);
   static void NotifyObserversOfMaxBandwidthChange(ConnectionType type,
                                                   double max_bandwidth_mbps);
@@ skipping 43 matching lines @@
 
   // Set true to disable non-test notifications (to prevent flakes in tests).
   static bool test_notifications_only_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkChangeNotifier);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_NETWORK_CHANGE_NOTIFIER_H_