Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1306403003: Remove javaEnabled setting. (Closed)

Created:
5 years, 3 months ago by dcheng
Modified:
5 years, 3 months ago
Reviewers:
haraken, battre
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, Will Harris
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove javaEnabled setting. As of M45, NPAPI support is (almost) completely gone, so Java will never be supported anyway. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201211

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -49 lines) Patch
M LayoutTests/fast/plugins/plugin-placeholder.html View 1 chunk +0 lines, -2 lines 1 comment Download
M LayoutTests/fast/plugins/plugin-placeholder-explicit-size.html View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAppletElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 2 chunks +2 lines, -25 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/plugins/NavigatorPlugins.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/plugins/NavigatorPlugins.cpp View 2 chunks +1 line, -9 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
Note: this depends on Chrome CL https://codereview.chromium.org/1313243002 landing first. https://codereview.chromium.org/1306403003/diff/1/LayoutTests/fast/plugins/plugin-placeholder.html File LayoutTests/fast/plugins/plugin-placeholder.html (left): https://codereview.chromium.org/1306403003/diff/1/LayoutTests/fast/plugins/plugin-placeholder.html#oldcode21 LayoutTests/fast/plugins/plugin-placeholder.html:21: ...
5 years, 3 months ago (2015-08-26 05:27:57 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-08-26 05:30:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306403003/1
5 years, 3 months ago (2015-08-26 06:14:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201211
5 years, 3 months ago (2015-08-26 07:54:59 UTC) #6
battre
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1318703002/ by battre@chromium.org. ...
5 years, 3 months ago (2015-08-26 08:43:26 UTC) #7
battre
5 years, 3 months ago (2015-08-26 08:46:34 UTC) #9
Message was sent while issue was closed.
I have tried to revert this because basically all compilers cried havoc. 

ninja -w dupbuild=err -C /b/build/slave/Linux_Builder__dbg_/build/src/out/Debug
accessibility_unittests accessibility_unittests_run app_list_unittests
app_list_unittests_run app_shell_unittests app_shell_unittests_run
aura_unittests aura_unittests_run base_unittests base_unittests_run
browser_tests browser_tests_run cacheinvalidation_unittests
cacheinvalidation_unittests_run cast_unittests cast_unittests_run cc_unittests
cc_unittests_run chrome chromedriver_unittests chromedriver_unittests_run
components_unittests components_unittests_run compositor_unittests
compositor_unittests_run content_browsertests content_browsertests_run
content_unittests content_unittests_run crypto_unittests crypto_unittests_run
dbus_unittests device_unittests device_unittests_run display_unittests
display_unittests_run events_unittests events_unittests_run
extensions_browsertests extensions_browsertests_run extensions_unittests
extensions_unittests_run gcm_unit_tests gcm_unit_tests_run gfx_unittests
gfx_unittests_run gl_unittests gn_unittests gn_unittests_run
google_apis_unittests google_apis_unittests_run gpu_unittests gpu_unittests_run
interactive_ui_tests interactive_ui_tests_run ipc_mojo_unittests ipc_tests
ipc_tests_run jingle_unittests jingle_unittests_run media_unittests
media_unittests_run midi_unittests midi_unittests_run mojo_common_unittests
mojo_common_unittests_run mojo_public_bindings_unittests
mojo_public_bindings_unittests_run mojo_public_environment_unittests
mojo_public_environment_unittests_run mojo_public_system_unittests
mojo_public_utility_unittests mojo_system_unittests nacl_loader_unittests
nacl_loader_unittests_run net_unittests net_unittests_run ppapi_unittests
printing_unittests printing_unittests_run remoting_unittests
remoting_unittests_run sandbox_linux_unittests sandbox_linux_unittests_run
skia_unittests skia_unittests_run sql_unittests sql_unittests_run
sync_integration_tests sync_integration_tests_run sync_unit_tests
sync_unit_tests_run ui_base_unittests ui_base_unittests_run
ui_touch_selection_unittests ui_touch_selection_unittests_run unit_tests
unit_tests_run url_unittests url_unittests_run views_unittests wm_unittests
wm_unittests_run -j50 -d explain
ninja: Entering directory
`/b/build/slave/Linux_Builder__dbg_/build/src/out/Debug'
ninja explain: output
obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8Internals.o
older than most recent input
../../out/Debug/gen/blink/core/testing/InternalSettingsGenerated.h (1440575734
vs 1440577085)
ninja explain:
obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8Internals.o
is dirty
ninja explain: output
obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8InternalSettings.o
older than most recent input
../../out/Debug/gen/blink/core/testing/InternalSettingsGenerated.h (1440575738
vs 1440577085)
ninja explain:
obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8InternalSettings.o
is dirty
ninja explain: obj/third_party/WebKit/Source/core/libwebcore_testing.a is dirty
[...]
Failing build because ninja reported work to do.
This means that after completing a compile, another was run and
it resulted in still having work to do (that is, a no-op build
wasn't a no-op). Consult the first "ninja explain:" line for a
likely culprit.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%...

Powered by Google App Engine
This is Rietveld 408576698