Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313243002: Remove command line flags and prefs for disabling Java. (Closed)

Created:
5 years, 4 months ago by dcheng
Modified:
5 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Will Harris
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove command line flags and prefs for disabling Java. Java requires NPAPI, and Chrome no longer supports NPAPI. Huzzah. BUG=470301 R=avi@chromium.org,thakis@chromium.org,tkent@chromium.org TBR=vitalybuka@chromium.org Committed: https://crrev.com/e5b8ee43ea3e25fae555fd45e1e7f03b73b63bec Cr-Commit-Position: refs/heads/master@{#345549}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/test_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/test_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/test_runner.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +0 lines, -1 line 2 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_helpers.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
dcheng
+thakis for chrome/ +vitalybuka for components/printing/ +tkent for components/test_runner/ +avi for content/ I don't think ...
5 years, 4 months ago (2015-08-25 23:19:07 UTC) #2
dcheng
On 2015/08/25 at 23:19:07, dcheng wrote: > +thakis for chrome/ > +vitalybuka for components/printing/ > ...
5 years, 4 months ago (2015-08-25 23:19:26 UTC) #3
Nico
lgtm, but: https://codereview.chromium.org/1313243002/diff/1/content/public/common/web_preferences.cc File content/public/common/web_preferences.cc (left): https://codereview.chromium.org/1313243002/diff/1/content/public/common/web_preferences.cc#oldcode87 content/public/common/web_preferences.cc:87: java_enabled(true), Maybe land a CL that switches ...
5 years, 4 months ago (2015-08-25 23:21:31 UTC) #4
tkent
test_runner lgtm.
5 years, 4 months ago (2015-08-25 23:30:51 UTC) #5
Avi (use Gerrit)
lgtm 👍🎉
5 years, 4 months ago (2015-08-26 00:47:26 UTC) #6
dcheng
TBRing vitalybuka@ https://codereview.chromium.org/1313243002/diff/1/content/public/common/web_preferences.cc File content/public/common/web_preferences.cc (left): https://codereview.chromium.org/1313243002/diff/1/content/public/common/web_preferences.cc#oldcode87 content/public/common/web_preferences.cc:87: java_enabled(true), On 2015/08/25 at 23:21:31, Nico wrote: ...
5 years, 4 months ago (2015-08-26 04:59:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313243002/1
5 years, 4 months ago (2015-08-26 04:59:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 06:02:20 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e5b8ee43ea3e25fae555fd45e1e7f03b73b63bec Cr-Commit-Position: refs/heads/master@{#345549}
5 years, 3 months ago (2015-08-26 06:03:02 UTC) #11
Vitaly Buka (NO REVIEWS)
5 years, 3 months ago (2015-08-26 16:30:30 UTC) #12
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698