Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1306243012: Add command line option to enable PPAPI win32k lockdown. (Closed)

Created:
5 years, 3 months ago by forshaw
Modified:
5 years, 3 months ago
Reviewers:
palmer, jam, Will Harris
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_render_font_code
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add command line option to enable PPAPI win32k lockdown. This patch adds a command line option (enable-win32k-lockdown-mimetypes) to selectively enable win32k lockdown on specific types of PPAPI content. This will not currently allow any PPAPI process to work under lockdown as further changes are necessary to remove usage of GDI. BUG=523278 Committed: https://crrev.com/d35dca1768aa8bf44af0e3318664f224fd88acf4 Cr-Commit-Position: refs/heads/master@{#349568}

Patch Set 1 #

Patch Set 2 : Rebased and made changes from review. #

Patch Set 3 : Rebased patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -15 lines) Patch
M content/browser/ppapi_plugin_process_host.cc View 1 5 chunks +20 lines, -7 lines 0 comments Download
M content/common/content_switches_internal.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/content_switches_internal.cc View 1 2 chunks +29 lines, -0 lines 0 comments Download
M content/common/sandbox_win.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/sandbox_win.cc View 1 2 chunks +29 lines, -8 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
forshaw
Please take a look.
5 years, 3 months ago (2015-09-03 00:04:10 UTC) #2
palmer
lgtm
5 years, 3 months ago (2015-09-15 21:55:53 UTC) #3
jam
lgtm
5 years, 3 months ago (2015-09-17 21:45:30 UTC) #5
Will Harris
On 2015/09/17 21:45:30, jam wrote: > lgtm content/common/sandbox_win.cc lgtm
5 years, 3 months ago (2015-09-17 22:03:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306243012/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306243012/40001
5 years, 3 months ago (2015-09-17 22:11:00 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-18 01:13:46 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 01:15:01 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d35dca1768aa8bf44af0e3318664f224fd88acf4
Cr-Commit-Position: refs/heads/master@{#349568}

Powered by Google App Engine
This is Rietveld 408576698