Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1351513002: Added common check for USER32 and GDI32 API availability. (Closed)

Created:
5 years, 3 months ago by forshaw
Modified:
5 years, 3 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added common check for USER32 and GDI32 API availability. This CL adds a check function to base to allow code to check if the USER32 and GDI32 API calls are available. Windows 8 and above allow an application to disable these API calls for security reasons and fallback when calling the API isn't consistent (such as returning error codes instead of handles). This can lead to undefined behaviour if code calls into these APIs while they are disabled. This check can be used to guard calls to these APIs and fallback if appropriate. BUG=523278 Committed: https://crrev.com/47161b3bd2e3291c3ee969efb21ab9ad74ca404b Cr-Commit-Position: refs/heads/master@{#349237}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed nits in review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M base/win/win_util.h View 1 chunk +7 lines, -0 lines 0 comments Download
M base/win/win_util.cc View 1 2 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
forshaw
Please take a look at this, as discussed.
5 years, 3 months ago (2015-09-16 11:33:25 UTC) #2
rvargas (doing something else)
lgtm after nits. https://codereview.chromium.org/1351513002/diff/1/base/win/win_util.cc File base/win/win_util.cc (right): https://codereview.chromium.org/1351513002/diff/1/base/win/win_util.cc#newcode83 base/win/win_util.cc:83: PROCESS_MITIGATION_SYSTEM_CALL_DISABLE_POLICY policy = {0}; nit: {} ...
5 years, 3 months ago (2015-09-16 20:15:42 UTC) #3
forshaw
https://codereview.chromium.org/1351513002/diff/1/base/win/win_util.cc File base/win/win_util.cc (right): https://codereview.chromium.org/1351513002/diff/1/base/win/win_util.cc#newcode83 base/win/win_util.cc:83: PROCESS_MITIGATION_SYSTEM_CALL_DISABLE_POLICY policy = {0}; On 2015/09/16 20:15:42, rvargas (slow ...
5 years, 3 months ago (2015-09-16 20:45:36 UTC) #4
forshaw
Thanks rvargas@ for a quick review. Much appreciated.
5 years, 3 months ago (2015-09-16 20:46:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351513002/20001
5 years, 3 months ago (2015-09-16 20:46:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-16 21:31:35 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 21:32:25 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47161b3bd2e3291c3ee969efb21ab9ad74ca404b
Cr-Commit-Position: refs/heads/master@{#349237}

Powered by Google App Engine
This is Rietveld 408576698