Dynamically create Gaia accounts when running E2E sync integration tests.

chrome/browser/sync/test/integration/sync_test.h

Index: chrome/browser/sync/test/integration/sync_test.h
diff --git a/chrome/browser/sync/test/integration/sync_test.h b/chrome/browser/sync/test/integration/sync_test.h
index dc9678d84fcb863fe1bfbe78da0c0a2fab3d3360..dfe7d86f2b62fcec2a23e5b0d881d908f116d54c 100644
--- a/chrome/browser/sync/test/integration/sync_test.h
+++ b/chrome/browser/sync/test/integration/sync_test.h
@@ -264,6 +264,11 @@ class SyncTest : public InProcessBrowserTest {
   // GAIA password used by the test case.
   std::string password_;
 
+  // Flag to indicate the need to create Gaia user account at runtime. This can

[pval...(no longer on Chromium), 2015/08/26 19:26:33]

s/Flag to indicate/Indicates/

IMO flag has the strong connotation of command-line flag

[shadi, 2015/09/03 22:17:08]

Done.

+  // only work when running against external servers with support for user
+  // creation via http requests.
+  bool create_gaia_account_at_runtime_;
+
   // Locally available plain text file in which GAIA credentials are stored.
   base::FilePath password_file_;
 
@@ -285,6 +290,14 @@ class SyncTest : public InProcessBrowserTest {
   // a profile then registers it as a testing profile.
   Profile* MakeProfile(const base::FilePath::StringType name);
 
+  // Create a Gaia account at runtime by accessing TestDataSetupServer server

[pval...(no longer on Chromium), 2015/08/26 19:26:34]

it's probably best to remove the reference to TestDataSetupServer since it is
not in Chromium

[shadi, 2015/09/03 22:17:08]

Done.

+  // part of E2E authentication stack.
+  // This function should only be called when running against external servers
+  // which use local authentication servers.
+  // Returns true if account creation was successful, false otherwise.
+  bool CreateGaiaAccount(const std::string& user_name,

[pval...(no longer on Chromium), 2015/08/26 19:26:34]

should user_name be username instead?

[shadi, 2015/09/03 22:17:08]

Done.

+                         const std::string& password);
+
   // Helper method used to read GAIA credentials from a local password file
   // specified via the "--password-file-for-test" command line switch.
   // Note: The password file must be a plain text file with exactly two lines --