Dynamically create Gaia accounts when running E2E sync integration tests.

chrome/browser/sync/test/integration/sync_test.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_SYNC_TEST_H_
 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_SYNC_TEST_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 246 matching lines @@
   // If non-empty, |contents| will be written to a profile's Preferences file
   // before the Profile object is created.
   void SetPreexistingPreferencesFileContents(const std::string& contents);
 
   // GAIA account used by the test case.
   std::string username_;
 
   // GAIA password used by the test case.
   std::string password_;
 
+  // Flag to indicate the need to create Gaia user account at runtime. This can

[pval...(no longer on Chromium), 2015/08/26 19:26:33]

s/Flag to indicate/Indicates/

IMO flag has the strong connotation of command-line flag

[shadi, 2015/09/03 22:17:08]

Done.

+  // only work when running against external servers with support for user
+  // creation via http requests.
+  bool create_gaia_account_at_runtime_;
+
   // Locally available plain text file in which GAIA credentials are stored.
   base::FilePath password_file_;
 
   // The FakeServer used in tests with server type IN_PROCESS_FAKE_SERVER.
   scoped_ptr<fake_server::FakeServer> fake_server_;
 
  private:
   // Helper to ProfileManager::CreateProfileAsync that creates a new profile
   // used for UI Signin. Blocks until profile is created.
   static Profile* MakeProfileForUISignin(const base::FilePath::StringType name);
 
   // Callback for CreateNewProfile() method. It runs the quit_closure once
   // profile is created successfully.
   static void CreateProfileCallback(const base::Closure& quit_closure,
                                     Profile* profile,
                                     Profile::CreateStatus status);
 
   // Helper to Profile::CreateProfile that handles path creation. It creates
   // a profile then registers it as a testing profile.
   Profile* MakeProfile(const base::FilePath::StringType name);
 
+  // Create a Gaia account at runtime by accessing TestDataSetupServer server

[pval...(no longer on Chromium), 2015/08/26 19:26:34]

it's probably best to remove the reference to TestDataSetupServer since it is
not in Chromium

[shadi, 2015/09/03 22:17:08]

Done.

+  // part of E2E authentication stack.
+  // This function should only be called when running against external servers
+  // which use local authentication servers.
+  // Returns true if account creation was successful, false otherwise.
+  bool CreateGaiaAccount(const std::string& user_name,

[pval...(no longer on Chromium), 2015/08/26 19:26:34]

should user_name be username instead?

[shadi, 2015/09/03 22:17:08]

Done.

+                         const std::string& password);
+
   // Helper method used to read GAIA credentials from a local password file
   // specified via the "--password-file-for-test" command line switch.
   // Note: The password file must be a plain text file with exactly two lines --
   // the username on the first line and the password on the second line.
   void ReadPasswordFile();
 
   // Helper method that starts up a sync test server if required.
   void SetUpTestServerIfRequired();
 
   // Helper method used to start up a local python test server. Note: We set up
@@ skipping 114 matching lines @@
   scoped_ptr<net::URLFetcherImplFactory> factory_;
 
   // The contents to be written to a profile's Preferences file before the
   // Profile object is created. If empty, no preexisting file will be written.
   std::string preexisting_preferences_file_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(SyncTest);
 };
 
 #endif  // CHROME_BROWSER_SYNC_TEST_INTEGRATION_SYNC_TEST_H_