Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1306083005: [tools/Perf] Disable pylint's long line check for urls (Closed)

Created:
5 years, 3 months ago by nednguyen
Modified:
5 years, 3 months ago
CC:
bashi, chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/Perf] Disable pylint's long line check for urls Rationale: it's hard to read, copy & paste URLs if they are splitted to multi lines. Context: https://codereview.chromium.org/1266833004/diff/140001/tools/perf/page_sets/blink_memory_mobile.py#newcode28 Committed: https://crrev.com/4d98928d9429c872c244c3a4bf6a7b004d6d0f8c Cr-Commit-Position: refs/heads/master@{#346108}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M tools/perf/page_sets/key_mobile_sites.py View 3 chunks +0 lines, -3 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites_repaint.py View 3 chunks +0 lines, -3 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites_smooth.py View 3 chunks +0 lines, -3 lines 0 comments Download
M tools/perf/pylintrc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
nednguyen
5 years, 3 months ago (2015-08-28 03:35:23 UTC) #3
nednguyen
5 years, 3 months ago (2015-08-28 03:36:27 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306083005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306083005/20001
5 years, 3 months ago (2015-08-28 03:37:16 UTC) #7
eakuefner
lgtm nicely done!
5 years, 3 months ago (2015-08-28 03:43:55 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/105815)
5 years, 3 months ago (2015-08-28 04:43:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306083005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306083005/20001
5 years, 3 months ago (2015-08-28 09:13:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 3 months ago (2015-08-28 09:43:21 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 09:43:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d98928d9429c872c244c3a4bf6a7b004d6d0f8c
Cr-Commit-Position: refs/heads/master@{#346108}

Powered by Google App Engine
This is Rietveld 408576698